https://bugzilla.redhat.com/show_bug.cgi?id=2328456
--- Comment #7 from Fabio Porcedda <[email protected]> --- (In reply to Michael Cronenworth from comment #6) > Sure! I'll update the spec and srpm since it's been almost 8 months. > > Spec URL: https://michael.cronenworth.com/RPMS/node-gyp.spec > SRPM URL: > https://michael.cronenworth.com/RPMS/node-gyp-13.0.1-0.1.fc46.src.rpm Issues: - Add a comment about the upstream status of the patch, even something like "not sent upstream because is specific for Fedora" - Use a better description than the summary, for example the first part of the project description or somethink like that: "node-gyp is a cross-platform command-line tool written in Node.js for compiling native addon modules for Node.js. It contains a vendored copy of the gyp-next project that was previously used by the Chromium team and extended to support the development of Node.js native addons." - Release should be >= 1 or use %autorelease - Because the system gyp is being used instead of the bundled one, remove it in %prep instead of copying it in %install "cp -rp package.json addon.gypi addon-rpm.gypi bin/ gyp/ lib/ %{buildroot}%{nodejs_sitelib}/%{name}" - upstream dependency is "node": "^22.22.2 || ^24.15.0 || >=26.0.0" but the Fedora package has an unversioned dependency, it should exclude nodejs20, build.log: WARNING: The nodejs(engine) dependency contains an OR (||) dependency: '^22.22.2 || ^24.15.0 || >=26.0.0. - In line 31 is being used an undefined macro that will be put literally in the final rpm, does it make sense? - Source2 is being included but not used, there are some tests that can be used in %check instead? Suggestions: - Use %autorelease and %autochangelog -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2328456 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202328456%23c7 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
