https://bugzilla.redhat.com/show_bug.cgi?id=2328456
--- Comment #11 from Fabio Porcedda <[email protected]> --- (In reply to Michael Cronenworth from comment #10) > Spec URL: https://michael.cronenworth.com/RPMS/node-gyp.spec > SRPM URL: https://michael.cronenworth.com/RPMS/node-gyp-13.0.1-1.fc46.src.rpm > > - I 'hard coded' nodejs 24 as the configure.js link. I'm unsure if this is > safe or not. Why exclude nodejs26? I think "Requires/BuildRequires: (nodejs24-devel or nodejs26-devel)" should be better. > - I had to disable two tests that required network access. Other tests > passed. Issue found: - Please add for each patch the upstream status - Because you are using the system gyp package you must remove in %prep the bundled version of gyp (rm -r gyp) - In the %description the reference to the bundled gyp-next should be removed because you use the system gyp - "Requires: nodejs(engine) > 20" still accept nodejs20, to fix that use "Requires: (nodejs24-devel or nodejs26-devel)" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2328456 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202328456%23c11 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
