https://bugzilla.redhat.com/show_bug.cgi?id=2483948



--- Comment #4 from BeƱat Garcia <[email protected]> ---
(In reply to Vitaly Kuznetsov from comment #3)
> Thank you for the review! I've added qemu-img as 'Recommends:' -- strictly
> speaking it is not 'Required'
> as you can use raw images with losetup or connect images in a different way
> but qemu-nbd certainly makes
> things easier. 
> 

Ack, thanks!

> The package is 'noarch' meaning it's pure Python but currently it can only
> deal with x86_64
> images, it is a known limitation. Aarch64 support is expected in the future.
> 

Probably not the smartest thing that I have tried out, but for the record: mock
builds were tested there too :)

> I did not fully get the comment regarding the Source, currently it is 
> 
> Source:        
> https://gitlab.com/vkuznets/cvmutils/-/archive/%version/cvmutils-%version.
> tar.gz
> 

It was a rather minor comment so you did not have to write the root of the url,
e.g. https://gitlab.com/vkuznets/cvmutils, twice. First for "Url: <>" and then
for "Source: <>", when for the latter you could have just used literally
%{url}/-/<whatever> instead.

> I've uploaded the updated stuff to the same location:
> 
> Spec URL: https://people.redhat.com/~vkuznets/cvmutils/python-cvmutils.spec
> SRPM URL:
> https://people.redhat.com/~vkuznets/cvmutils/python-cvmutils-0.3.2-1.fc43.
> src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2483948

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202483948%23c4

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to