https://bugzilla.redhat.com/show_bug.cgi?id=2521510

Ben Beasley <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
                   |needinfo?(code@musicinmybra |
                   |in.net)                     |
                   |needinfo?(code@musicinmybra |
                   |in.net)                     |
             Status|ASSIGNED                    |POST



--- Comment #3 from Ben Beasley <[email protected]> ---
Looking at the spec-file diff, a properly-documented patch has been added using
rust2rpm -p to remove the two mentioned features:

+# Manually created patch for downstream crate metadata changes
+# * drop openssl-on-win32 feature; Windows-only, forwards to a libssh2-sys
+#   feature not built in Fedora
+# * drop vendored-openssl feature; bundled OpenSSL, forwards to a libssh2-sys
+#   feature not built in Fedora
+Patch:          ssh2-fix-metadata.diff

The spec file was re-generated with rust2rpm, and the two feature metapackages
are correctly absent from the spec file.

The only other difference is that the command to fix the executable files was
lost:

-# Upstream published these plain files with the executable bit set
-chmod -x src/listener.rs tests/all/agent.rs tests/all/knownhosts.rs \
-  LICENSE-APACHE LICENSE-MIT README.md

You can prevent this by adding the lines to rust2rpm.toml

[scripts.prep]
post = [
    """\
# Upstream published these plain files with the executable bit set
chmod -x src/listener.rs tests/all/agent.rs tests/all/knownhosts.rs \
  LICENSE-APACHE LICENSE-MIT README.md\
"""
]

The package is APPROVED; please fix the above on import.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

  https://release-monitoring.org/project/392056/

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2521510

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202521510%23c3

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to