Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=786668

Ofer Schreiber <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #1 from Ofer Schreiber <[email protected]> 2012-02-07 05:37:27 
EST ---
I'm not a packager, so I can't be a sponsor yet.
Some comments though:
1. You're missing two BuildRequires needed for python packages:
  a. python2-devel
  b. python-setuptools-devel

2. A package shouldn't run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install. (unless you're going to support EPEL5)

3. The %python_sitelib defenition is not needed in fedora

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to