Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=819678 --- Comment #3 from Richard Shaw <[email protected]> 2012-05-08 09:40:23 EDT --- Quick spec review: 1. I see some things that are no longer needed like BuildRoot:, rm -rf $RPM_BUILD_ROOT in %install, %clean, and %defattr in %files but I'm assuming that these are in the Fedora cmake package so I guess it's not worth deviating from their package. 2. Should the Require for the -gui package be arch dependent? i.e.: Requires: %{name} = %{version}-%{release} to Requires: %{name}${?_isa} = %{version}-%{release} There's a lot of rpmlint output but I'm assuming it's largely the same as the regular cmake package in Fedora. The only two things I think should be fixed are: cmake28.src:24: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 24) cmake28.x86_64: E: non-executable-script /usr/share/cmake28/Modules/SquishRunTestCase.sh 0644L /bin/sh -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
