https://bugzilla.redhat.com/show_bug.cgi?id=817622

--- Comment #3 from Rex Dieter <[email protected]> ---
Initial comments:

1. while you have 
Obsoletes:    libkgoogle < 0.3.2
Provides:    libkgoogle = %{version}-%{release}
you probably ought to do the same for libkgoogle-devel too in the -devel subpkg

2. cosmetics, but
s/%description -n %{name}-devel/%description devel/

3.  These are redundant (already pulled in implicitly via kdelibs-devel), can
be removed:
BuildRequires:    cmake 
BuildRequires:    qt-devel 

4.  %files devel is missing ownership of several dirs, replace
%{_kde4_includedir}/libkgapi/*
...
%{_libdir}/cmake/LibKGAPI/*.cmake
with
%{_kde4_includedir}/libkgapi/
...
%{_libdir}/cmake/LibKGAPI/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to