https://bugzilla.redhat.com/show_bug.cgi?id=817622
--- Comment #7 from Mario Santagiuliana <[email protected]> --- (In reply to comment #6) > (In reply to comment #5) > > Do you think I should remove comments in spec file? > Are you considering using git snapshots for your package in the near future? > If not, then remove them. This depends on how many times upstream release new stable versions. Sometimes there are some useful bug fix on upstream but stable version is not release quickly. I prefer to wait and see how the upstream works in the next future. Ok? > You should drop rm -rf %{buildroot} at %install Here I follow an old Rex Dieter request, for the previous package: https://bugzilla.redhat.com/show_bug.cgi?id=711058#c25 > imho this project url is better: http://projects.kde.org/libkgoogle I agree with you but official release package is provides fist time by developer website. Also the kde repository should change to new libkgapi... > oh, and can you align your indentations please. It looks messy :) Sorry, which indentation? I see everything well...using my browser web or my text editor (Vim). -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
