Hi Brandon,

> Would PacketFence internals be affected by selectively including
> additional characters to the regular expression? or is the current
> list of allowed characters simply a sensible default?

These were made before my time here but I bet they are a sensible 
default and they are defensive to limit potential problem with the shell.

Feel free to allow more characters.

Be careful with two things:
- the grammar needs to be compiled as it's 
lib/pf/pfcmd/pfcmd_pregrammar.pm that is used by pfcmd on run-time
- I think that lib/pf/pfcmd/pfcmd.pm and pfcmd_pregrammar.pm files will 
be replaced by an RPM upgrade. So make sure you re-apply your changes, 
recompile the grammar and replace pfcmd_pregrammar.pm with your custom 
one on every upgrade.

I would be open to accepting more characters on certain fields. Feel 
free to send me a patch if you do so and are willing to share.

Thanks
-- 
Olivier Bilodeau
obilod...@inverse.ca  ::  +1.514.447.4918 *115  ::  www.inverse.ca
Inverse inc. :: Leaders behind SOGo (www.sogo.nu) and PacketFence 
(www.packetfence.org)

------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Packetfence-devel mailing list
Packetfence-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/packetfence-devel

Reply via email to