On Mon, Jun 28, 2010 at 12:52 AM, Allan McRae <[email protected]> wrote: > So, if someone ever wants to use it outside util.c, we need to rename the > function and add its header. Call it forward thinking to do it properly the > first time. Any decent compiler removes unneeded functions on any include > anyway so there is no loss in doing this but there is potential future gain. > > I'd say not doing that way is "retarded", but really there is no call to > start being offensive around here. >
Right... > No, you said: > I strongly disagree with making this void, but until all these void > funcions get a rework then I guess this is better than outright ignoring. > > That tells me that this is a commit up for consideration as it improves the > current situation. Also, submitting a whole patch in proper git format > indicates that you want it considered. > > Or were you assuming that I did not understand you previous "make a > asprintf wrapper" comment... Look, hacking on this is fun, but these little husband-wife bickerings are not. I'm gonna have to call it quits. For the record, I meant no offense with my technical remarks. ;) Andres P
