Hi Steffen, (hi list) you said on IRC we should check the new camelCase to camel_case feature. It works fine for me. Thank you for adding it to Padre!
Two observations: 1. Is there a reason that it's "Change variable style" in the context menu and "Change variable casing" in the menu bar? 2. I get the following errors when running the tests for PPIx::EditorTools: PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t xt/*.t t/00-use.t ......................... ok t/01-findunmatchedbrace.t .......... ok t/02-findvariabledeclaration.t ..... ok t/03-introducetemporaryvariable.t .. ok t/04-renamepackage.t ............... ok t/05-renamepackagefrompath.t ....... ok t/06-camelcasing.t ................. ok t/07-renamevariable.t .............. ok xt/95-prereq.t ..................... 1/1 _get_prereqs: Error loading Build.PL: # Failed test ' Build.PL did not return a true value. # ' # at /usr/local/share/perl/5.10.1/Test/Prereq.pm line 220. # # Looks like you failed 1 test of 1. xt/95-prereq.t ..................... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests xt/96-kwalitee.t ................... skipped: Test::Kwalitee not installed; skipping xt/97-critic.t ..................... 1/8 # Failed test 'Test::Perl::Critic for "blib/lib/PPIx/EditorTools.pm"' # at /usr/local/share/perl/5.10.1/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "blib/lib/PPIx/EditorTools.pm": # Found use of croak. Use an exception instead at line 62, column 5. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # Unreachable code at line 63, column 5. Consider removing it. (Severity: 4) # Always unpack @_ first at line 73, column 1. See page 178 of PBP. (Severity: 4) # "%vars" is declared but not used at line 100, column 5. Unused variables clutter code and make it harder to read. (Severity: 3) # Regular expression without "/x" flag at line 147, column 35. See page 236 of PBP. (Severity: 3) # Subroutine "find_variable_declaration" with high complexity score (35) at line 217, column 1. Consider refactoring. (Severity: 3) # Regular expression without "/x" flag at line 228, column 26. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 236, column 17. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 278, column 43. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 291, column 36. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 301, column 45. See page 236 of PBP. (Severity: 3) # Mixed high and low-precedence booleans at line 304, column 29. See page 70 of PBP. (Severity: 4) xt/97-critic.t ..................... 2/8 # Failed test 'Test::Perl::Critic for "blib/lib/PPIx/EditorTools/FindVariableDeclaration.pm"' # at /usr/local/share/perl/5.10.1/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "blib/lib/PPIx/EditorTools/FindVariableDeclaration.pm": # Found use of croak. Use an exception instead at line 63, column 35. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # Found use of croak. Use an exception instead at line 64, column 35. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # Found use of croak. Use an exception instead at line 71, column 5. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # Found use of croak. Use an exception instead at line 74, column 5. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) xt/97-critic.t ..................... 4/8 # Failed test 'Test::Perl::Critic for "blib/lib/PPIx/EditorTools/IntroduceTemporaryVariable.pm"' # at /usr/local/share/perl/5.10.1/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "blib/lib/PPIx/EditorTools/IntroduceTemporaryVariable.pm": # Found use of croak. Use an exception instead at line 79, column 46. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # Found use of croak. Use an exception instead at line 80, column 46. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # Regular expression without "/x" flag at line 83, column 46. See page 236 of PBP. (Severity: 3) # "die" used instead of "croak" at line 90, column 5. See page 283 of PBP. (Severity: 3) # Found use of die. Use an exception instead at line 90, column 5. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # "die" used instead of "croak" at line 93, column 5. See page 283 of PBP. (Severity: 3) # Found use of die. Use an exception instead at line 93, column 5. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # Regular expression without "/x" flag at line 121, column 38. See page 236 of PBP. (Severity: 3) # Lvalue form of "substr" used at line 128, column 40. See page 165 of PBP. (Severity: 3) # Lvalue form of "substr" used at line 129, column 49. See page 165 of PBP. (Severity: 3) # Capture variable used outside conditional at line 138, column 15. See page 253 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 138, column 63. See page 236 of PBP. (Severity: 3) # Lvalue form of "substr" used at line 143, column 7. See page 165 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 147, column 14. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 148, column 14. See page 236 of PBP. (Severity: 3) xt/97-critic.t ..................... 5/8 # Failed test 'Test::Perl::Critic for "blib/lib/PPIx/EditorTools/RenamePackage.pm"' # at /usr/local/share/perl/5.10.1/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "blib/lib/PPIx/EditorTools/RenamePackage.pm": # Code before warnings are enabled at line 4, column 1. See page 431 of PBP. (Severity: 4) # Magic variable "$^W" should be assigned as "local" at line 5, column 6. See pages 81,82 of PBP. (Severity: 4) # Subroutine name is a homonym for builtin function at line 63, column 1. See page 177 of PBP. (Severity: 4) # Found use of croak. Use an exception instead at line 66, column 45. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # "die" used instead of "croak" at line 72, column 10. See page 283 of PBP. (Severity: 3) # Found use of die. Use an exception instead at line 72, column 10. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # Found use of croak. Use an exception instead at line 73, column 44. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # Found use of croak. Use an exception instead at line 74, column 44. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # Failed test 'Test::Perl::Critic for "blib/lib/PPIx/EditorTools/RenamePackageFromPath.pm"' # at /usr/local/share/perl/5.10.1/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "blib/lib/PPIx/EditorTools/RenamePackageFromPath.pm": # Subroutine name is a homonym for builtin function at line 74, column 1. See page 177 of PBP. (Severity: 4) # Found use of croak. Use an exception instead at line 77, column 35. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # Regular expression without "/x" flag at line 83, column 21. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 85, column 17. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 86, column 40. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 88, column 38. See page 236 of PBP. (Severity: 3) xt/97-critic.t ..................... 7/8 # Failed test 'Test::Perl::Critic for "blib/lib/PPIx/EditorTools/RenameVariable.pm"' # at /usr/local/share/perl/5.10.1/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "blib/lib/PPIx/EditorTools/RenameVariable.pm": # Subroutine name is a homonym for builtin function at line 69, column 1. See page 177 of PBP. (Severity: 4) # Subroutine "rename" with high complexity score (31) at line 69, column 1. Consider refactoring. (Severity: 3) # Found use of croak. Use an exception instead at line 72, column 45. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # Found use of croak. Use an exception instead at line 73, column 45. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # Found use of croak. Use an exception instead at line 78, column 9. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # Found use of croak. Use an exception instead at line 82, column 9. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # "die" used instead of "croak" at line 88, column 5. See page 283 of PBP. (Severity: 3) # Found use of die. Use an exception instead at line 88, column 5. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # "die" used instead of "croak" at line 91, column 5. See page 283 of PBP. (Severity: 3) # Found use of die. Use an exception instead at line 91, column 5. Exception objects should be used instead of the standard Perl error mechanism. (Severity: 4) # Regular expression without "/x" flag at line 129, column 21. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 137, column 24. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 142, column 24. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 156, column 7. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 159, column 21. See page 236 of PBP. (Severity: 3) # Hard tabs used at line 187, column 29. See page 20 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 187, column 29. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 213, column 17. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 216, column 13. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 217, column 13. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 226, column 17. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 231, column 17. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 232, column 17. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 235, column 17. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 236, column 17. See page 236 of PBP. (Severity: 3) # Regular expression without "/x" flag at line 245, column 18. See page 236 of PBP. (Severity: 3) xt/97-critic.t ..................... 8/8 # Failed test 'Test::Perl::Critic for "blib/lib/PPIx/EditorTools/ReturnObject.pm"' # at /usr/local/share/perl/5.10.1/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "blib/lib/PPIx/EditorTools/ReturnObject.pm": # Always unpack @_ first at line 77, column 1. See page 178 of PBP. (Severity: 4) # Always unpack @_ first at line 82, column 1. See page 178 of PBP. (Severity: 4) # Looks like you failed 7 tests of 8. xt/97-critic.t ..................... Dubious, test returned 7 (wstat 1792, 0x700) Failed 7/8 subtests xt/98-pod.t ........................ ok xt/99-podcoverage.t ................ 1/8 # Failed test 'Pod coverage on PPIx::EditorTools' # at /usr/local/share/perl/5.10.1/Test/Pod/Coverage.pm line 126. # Coverage for PPIx::EditorTools is 11.1%, with 8 naked subroutines: # code # element_depth # find_token_at_location # find_unmatched_brace # find_variable_declaration # get_all_variable_declarations # ppi # process_doc # Failed test 'Pod coverage on PPIx::EditorTools::IntroduceTemporaryVariable' # at /usr/local/share/perl/5.10.1/Test/Pod/Coverage.pm line 126. # Coverage for PPIx::EditorTools::IntroduceTemporaryVariable is 40.0%, with 3 naked subroutines: # expression # introduce # location # Failed test 'Pod coverage on PPIx::EditorTools::FindVariableDeclaration' # at /usr/local/share/perl/5.10.1/Test/Pod/Coverage.pm line 126. # Coverage for PPIx::EditorTools::FindVariableDeclaration is 50.0%, with 1 naked subroutine: # location # Failed test 'Pod coverage on PPIx::EditorTools::RenamePackageFromPath' # at /usr/local/share/perl/5.10.1/Test/Pod/Coverage.pm line 126. # Coverage for PPIx::EditorTools::RenamePackageFromPath is 66.7%, with 1 naked subroutine: # replacement # Looks like you failed 4 tests of 8. xt/99-podcoverage.t ................ Dubious, test returned 4 (wstat 1024, 0x400) Failed 4/8 subtests Test Summary Report ------------------- xt/95-prereq.t (Wstat: 256 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 xt/97-critic.t (Wstat: 1792 Tests: 8 Failed: 7) Failed tests: 1, 3-8 Non-zero exit status: 7 xt/99-podcoverage.t (Wstat: 1024 Tests: 8 Failed: 4) Failed tests: 1, 3-4, 8 Non-zero exit status: 4 Files=13, Tests=155, 8 wallclock secs ( 0.11 usr 0.01 sys + 7.72 cusr 0.40 csys = 8.24 CPU) Result: FAIL Failed 3/13 test programs. 12/155 subtests failed. _______________________________________________ Padre-dev mailing list Padre-dev@perlide.org http://mail.perlide.org/mailman/listinfo/padre-dev
