Hi, Zeno Gantner wrote: > Hi Steffen, (hi list) > > you said on IRC we should check the new camelCase to camel_case feature. > It works fine for me. Thank you for adding it to Padre!
thanks for the feedback! > Two observations: > 1. Is there a reason that it's "Change variable style" in the context menu and > "Change variable casing" in the menu bar? In mid-flight, I realized that it's really more of a style than just casing. I forgot to change the "casing" in the menu bar. > 2. I get the following errors when running the tests for PPIx::EditorTools: > > PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" > "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t xt/*.t > t/00-use.t ......................... ok > t/01-findunmatchedbrace.t .......... ok > t/02-findvariabledeclaration.t ..... ok > t/03-introducetemporaryvariable.t .. ok > t/04-renamepackage.t ............... ok > t/05-renamepackagefrompath.t ....... ok > t/06-camelcasing.t ................. ok > t/07-renamevariable.t .............. ok These are the two relevant tests. The following are author tests: > xt/95-prereq.t ..................... 1/1 _get_prereqs: Error loading Build.PL: > > # Failed test ' Build.PL did not return a true value. > # ' > # at /usr/local/share/perl/5.10.1/Test/Prereq.pm line 220. > # > # Looks like you failed 1 test of 1. ??? > xt/95-prereq.t ..................... Dubious, test returned 1 (wstat 256, > 0x100) > Failed 1/1 subtests > xt/96-kwalitee.t ................... skipped: Test::Kwalitee not > installed; skipping > xt/97-critic.t ..................... 1/8 > # Failed test 'Test::Perl::Critic for "blib/lib/PPIx/EditorTools.pm"' > # at /usr/local/share/perl/5.10.1/Test/Perl/Critic.pm line 110. Well, running Perl::Critic here is... an interesting choice. Take this as an example: > # Regular expression without "/x" flag at line 236, column 17. See > page 236 of PBP. (Severity: 3) Huh? I mean, I don't know if this is some giant regexp, but if it's a small, innocent regexp like most, I don't see the point of that PBP recommendation. [...] > # Found use of croak. Use an exception instead at line 74, column 5. > Exception objects should be used instead of the standard Perl error > mechanism. (Severity: 4) Yeah. And Class::Std. I have similar feelings about some of the POD coverage failures: > xt/99-podcoverage.t ................ 1/8 > # Failed test 'Pod coverage on PPIx::EditorTools' > # at /usr/local/share/perl/5.10.1/Test/Pod/Coverage.pm line 126. > # Coverage for PPIx::EditorTools is 11.1%, with 8 naked subroutines: > # code > # element_depth > # find_token_at_location > # find_unmatched_brace > # find_variable_declaration > # get_all_variable_declarations > # ppi > # process_doc [...] To me, all these author test failures look kind of spurious. Cheers, Steffen _______________________________________________ Padre-dev mailing list Padre-dev@perlide.org http://mail.perlide.org/mailman/listinfo/padre-dev
