Re: Problems with "use diagnostics;"

[Steffen Mueller]

Roderich Schupp (ext) schrieb:
The Module::ScanDeps patch seems to do the job, but is there
a reason why you implemented the search strategy for
perldiag.pod differently from diagnostics.pm?

Not really. Just because this way, it is somewhat in sync with the rest 
of the module's file searches. Also, it might work in edge cases if 
_find_in_inc honors those. (CODE refs in @INC...)

The PAR patch will now read correctly perldiag.pod from the zip,
but the regex in the last line

       for(map "$_\\n\\n", split/\\r?\\n(?:\\r?\\n)*/, $contents) ',

results in a blank line inserted after each line 
grabbed from the pod (this regex is unchanged by your
patch - seems nobody noticed this behaviour before). The split
is supposed to mimick reading perldiag.pod "by paragraphs",
i.e. with $/="". The following

       for(map "$_\\n\\n", split/(?:\\r?\\n){2,}/, $contents) ',

does the trick. Tested on Solaris 9 (Perl 5.8.0) and
Cygwin (Perl 5.8.7).

Doh. I never even expended the 20 seconds to understand the regex. I'll 
change it in svn unless you already did so.

Thanks,
Steffen