On Thu, 21 Jun 2007, Steve Hay wrote:
> I've got around that by removing the XSRETURN_YES from the end of
> boot_Win32CORE(), which probably makes sense given that I declared it as
> "void" above.
Yes, that is correct. You should also redefine boot_Win32CORE from
XS(boot_Win32CORE)
to
void boot_Win32CORE(pTHX)
and get rid of the dXSARGS. Call it with an aTHX instead.
> I now find that PAR-Packer builds and tests OK. So perhaps we need
> something like the attached patch in blead?
Yes, but I would leave the call in init_os_extras() instead of moving it
to parse_body(). The whole point of having init_os_extras() is to move
this kind of code out of conditionally compiled blocks in perl.c.
> The one thing that I'm not sure of, though, is how to tell when we're
> building as part of miniperle.exe. In the patch I've tested for
> PERL_DEBUGGING_MSTATS, which is just one perl.exe build option that I
> happen to be using that doesn't get used when building miniperl.exe. Is
> there a #define that identifies miniperl.exe compilation, or do we need
> to add one?
I couldn't find one either, so we may have to add one. It will be easy
for Win32, but for Cygwin you probably need to get it into Configure. :)
Cheers,
-Jan
