Sorry, with that patch applied I get lots of test failures:
Failed Test Stat Wstat Total Fail List of
Failed
------------------------------------------------------------------------
-------
t/10-case-insensitive-keys.t 2 512 ?? ?? ??
t/2-static_functional_interface_fake.t 33 8448 224 33 3 7
10-13 131-
133 147
151
160
168-177
183 189
195
201 203
212
215
221-224
t/4-static_functional_interface_options_f 94 24064 387 94 48-50
64 68 77
85-94
100 106
112 118
120-
122 136
140
149
157-166
172 178
184
190
192-194
208 212
221
229-238
244
250 256
262
264-266
280
284 293
301-
310 316
322
328 334
336-
337 346
350
363-369
375
381 387
t/8-check_duplicated_entries.t 7 1792 25 7 4 13 16
22-25
t/9-check_path_to_inc_name.t 1 256 6 1 6
1 test skipped.
Failed 5/11 test scripts. 135/7644 subtests failed.
Files=11, Tests=7644, 29 wallclock secs ( 0.00 cusr + 0.00 csys = 0.00
CPU)
Without the patch, the only failure is that Data::Dump isn't installed
(which the pre-requisite checking evidently didn't spot):
t/10-case-insensitive-keys......................Can't locate
Data/Dump.pm in @IN
C (@INC contains: t t/data/case-insensitive-keys
C:\svnclients\Module-ScanDeps\i
nc C:\svnclients\Module-ScanDeps\blib\lib
C:\svnclients\Module-ScanDeps\blib\arc
h C:/perl5/lib C:/perl5/site/lib .) at t/10-case-insensitive-keys.t line
50.
BEGIN failed--compilation aborted at t/10-case-insensitive-keys.t line
50.
Sorry for the poor email style too--I've just had to switch to Outlook
:-(
Steve
-----Original Message-----
From: Steffen Mueller [mailto:[EMAIL PROTECTED]
Sent: 20 July 2007 15:02
To: Steve Hay
Cc: [email protected]
Subject: Re: Module-ScanDeps-0.75 broken?
Steve Hay schrieb:
> Grr. That fixes the scandeps program output, but doesn't fix my PAR
> problem because PAR::Packer::pack_manifest_hash() directly calls
> Module::ScanDeps::add_deps() later on (line 739 of VERSION 0.975). It
is
> *that* call which actually adds Decrypt.dll to the PAR package, and
once
> again that call is screwed up if the foreach-loop in
> Module::ScanDeps::scan_deps() has been run earlier.
Hi Steve,
I'm still puzzled and can't spend a lot of time on this, sorry. If you
apply the attached patch to the svn head, does it help? It's not a
solution, but I'd rather have duplicates than missed dlls.
On a side note: Do you think it would be possible to write a short test
for the bug? If so, please feel free to commit it to the repository.
Best regards,
Steffen
=== lib/Module/ScanDeps.pm
==================================================================
--- lib/Module/ScanDeps.pm (revision 1827)
+++ lib/Module/ScanDeps.pm (local)
@@ -470,7 +470,8 @@
warn "# Couldn't find include name for $path\n" if $warn;
}
} else {
- (my $vol, my $dir, $inc_name) = File::Spec->splitpath($path);
+ #(my $vol, my $dir, $inc_name) = File::Spec->splitpath($path);
+ $inc_name = $path; # prefer duplicates over missed shared
libraries!
}
return $inc_name;
