On Sat, Nov 17, 2007 at 02:01:06AM -0500, Steffen Müller via RT <[EMAIL 
PROTECTED]> wrote:
> Would it be possible that you try this again after replacing
> 
>  open my $fh, '<', $par;
> 
> with
> 
>  open my $fh, '<', $par or die $!;

Sorry, I reported futher info to the wrong address :) Here are my earlier
findings:

I used:

   $PERL/bin/perl $PERL/bin/pp $GUI --icon win32/client.ico -C -I 
"//.host/Shared Folders/root/src/Crossfire" -I . -o deliantra.exe -A addlist 
bin/deliantra

which resulted in an open for "//.host/Shared Folders/root/src/Crossfire" in
the given code segment, which failed because presumably, under windows, you
cannot open() directories.

> so we get a better error message? I am not sure whether a silent failure
> is acceptable here, so I'm not sure whether that line should end with
> 'or return;' or 'or die "blah, blah, sensible error message here: $!";'.
> It should certainly not be without error checking of some sort because
> it's bound to fail badly on the binmode() call in the case of an error.

I have no idea what its for, as -I specifies a diretcory only, so opening
it must be caused by some deeper logic bug somewhere.

> That line, however bad it may be, has been there forever, so I suspect
> it's actually a different piece of code which changed between 0.972 and
> 6 which is causing the problem, but I can't track it down easily.

Likely, as I was using that -I switch forever.

-- 
                The choice of a       Deliantra, the free code+content MORPG
      -----==-     _GNU_              http://www.deliantra.net
      ----==-- _       generation
      ---==---(_)__  __ ____  __      Marc Lehmann
      --==---/ / _ \/ // /\ \/ /      [EMAIL PROTECTED]
      -=====/_/_//_/\_,_/ /_/\_\

Reply via email to