Karl,

Your patch seems overly complicated.  There is exactly one check in 
vtkFileSeriesReader to determine whether the internal reader has time, and that 
is in RequestInformation.  It is a lot less intrusive to just add a condition 
to that check there.  I've attached a patch that implements the no-time flag in 
this way.  (BTW, I changed the name from IgnoreTimeStepValues to 
IgnoreReaderTime since a reader can in fact specify time without specifying 
time steps.)

-Ken


On 9/18/09 4:47 AM, "Karl König" <[email protected]> wrote:

Hi,

I dug deeper into the class FileSeriesReader and found out that despite
what I thought and posted earlier everything is already there to be able
to implement a toggle to use/ignore time step values contained in a file
series. I'd like to propose the attached patch. It can be tested with
the attached minimal time series reader plugin, sample input files are
contained. The plugin's server manager XML has been extended to expose
the IgnoreTimeStepValues checkbox provided by the patched class
FileSeriesReader.

I don't see the patch interfering with existing readers relying on class
FileSeriesReader.
Any thoughts?

Thanks in advance for feedback,
Karl



   ****      Kenneth Moreland
    ***      Sandia National Laboratories
***********
*** *** ***  email: [email protected]
**  ***  **  phone: (505) 844-8919
    ***      web:   http://www.cs.unm.edu/~kmorel

Attachment: vtkFileSeriesReader.patch
Description: vtkFileSeriesReader.patch

_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the ParaView Wiki at: 
http://paraview.org/Wiki/ParaView

Follow this link to subscribe/unsubscribe:
http://www.paraview.org/mailman/listinfo/paraview
              • ... Utkarsh Ayachit
          • ... Moreland, Kenneth
            • ... Karl König
              • ... Moreland, Kenneth
            • ... Karl König
              • ... Karl König
              • ... Moreland, Kenneth
              • ... Stephane PLOIX
              • ... Karl König
              • ... Karl König
              • ... Moreland, Kenneth
              • ... Karl König
              • ... Moreland, Kenneth
              • ... Karl König
              • ... Moreland, Kenneth
      • [... Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]
        • ... Utkarsh Ayachit
  • Re: [Parav... Karl König

Reply via email to