ext/nqp-rx/src/stage0/nqp-setting.pm is failing 3 coding standards tests:
t/codingstd/copyright.t
t/codingstd/perlcritic.t
t/codingstd/svn_id.t
The test failure reports are attached. (It was also failing
t/distro/file_metadata.t, but I think I have fixed that in r46701.)
This file is written in NQP -- which might mean that some of our coding
standards developed for Perl 5 files ought not to apply. But what is
more important here is that this file is (a) a generated file stored in
the Parrot repository for (I am told) bootstrapping purposes; and (b)
generated outside of Parrot.
Looking into this file, we see:
# This file automatically generated by build/gen_setting.pl.
However, there is no file called gen_setting.pl in the Parrot MANIFEST
or SVN repository.
From looking at dalek's posts on #parrot, my *guess* is that this file
is actually generated in the NQP repository and then deposited in the
ext/ directory inside the Parrot repository.
So we have two problems:
1. How do we get this file to satisfy our codingstd tests in time for
Tuesday's release? (These failures preclude a PASS on 'make codetest'
and therefore on the 'make fulltest' the release manager has to run.)
2. More generally, what standards must files deposited in ext/ meet?
Thank you very much.
kid51
$ perl t/codingstd/copyright.t ext/nqp-rx/src/stage0/nqp-setting.pm
1..3
not ok 1 - Copyright statement exists
# Failed test 'Copyright statement exists'
# at t/codingstd/copyright.t line 91.
# No copyright statement found in 1 files:
# ext/nqp-rx/src/stage0/nqp-setting.pm
# The copyright statement should read something like:
# Copyright (C) C<start-year>-C<last-year-modified>, Parrot Foundation.
# To find the C<start-year>, use a command such as:
# svn log C<filename> | grep 'lines' | tail -n 1
# To find the C<last-year-modified>, use a command such as:
# svn log C<filename> | grep 'lines' | head -n 1
ok 2 - Copyright statement in the right format
ok 3 - Duplicate Copyright statements # TODO duplicate copyrights exist.
# Looks like you failed 1 test of 3.
$ perl t/codingstd/perlcritic.t ext/nqp-rx/src/stage0/nqp-setting.pm
1..1
not ok 1 - Test::Perl::Critic for "ext/nqp-rx/src/stage0/nqp-setting.pm"
# Failed test 'Test::Perl::Critic for "ext/nqp-rx/src/stage0/nqp-setting.pm"'
# at t/codingstd/perlcritic.t line 95.
#
# Perl::Critic found these violations in "ext/nqp-rx/src/stage0/nqp-setting.pm":
# Found misplaced shebang line at ext/nqp-rx/src/stage0/nqp-setting.pm line 6
# Missing properly located perl coda for parrot source at
ext/nqp-rx/src/stage0/nqp-setting.pm line 8
# Looks like you failed 1 test of 1.
$ perl t/codingstd/svn_id.t ext/nqp-rx/src/stage0/nqp-setting.pm
1..1
not ok 1 - Id keyword line exists
# Failed test 'Id keyword line exists'
# at t/codingstd/svn_id.t line 82.
# No Id keyword line found in 1 files:
# ext/nqp-rx/src/stage0/nqp-setting.pm
# Looks like you failed 1 test of 1.
_______________________________________________
http://lists.parrot.org/mailman/listinfo/parrot-dev
