#426: install_files.pl and install_dev_files.pl have a fair bit of duplicate
code
---------------------+------------------------------------------------------
Reporter: wayland | Type: patch
Status: new | Priority: normal
Milestone: | Component: install
Version: 0.9.1 | Severity: medium
Keywords: install | Lang:
Patch: new | Platform:
---------------------+------------------------------------------------------
Changes (by jkeenan):
* cc: jk...@… (added)
* keywords: => install
* patch: => new
Comment:
1. Since I've done a lot of work over the last 2-1/2 years refactoring
code out of our ''.pl'' programs into ''.pm'' modules, I'm predisposed to
like this patch. However, I'd also like to get some test files for the
subroutines now extracted into Parrot::Install. Do you think you could
work on that (or work on that with me)?
2. For consistency with other ''.pl'' files in the distro, I recommend:
{{{
use lib qw( lib );
}}}
... rather than
{{{
#! perl -Ilib
}}}
3. Could sub ''install_files()'' be refactored so that the list of files
is passed by reference rather than by value? ''I.e.,''
{{{
my($destdir, $dryrun, $filesref) = @_;
my($src, $dest, $mode);
print("Installing ...\n");
foreach ( @{ $filesref } ) {
}}}
... with appropriate changes in the two callers?
Thank you very much.[[BR]]
kid51
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/426#comment:1>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
