#751: test failures related to src/pmc/handle.pmc
--------------------+-------------------------------------------------------
Reporter: mikehh | Type: bug
Status: new | Priority: normal
Milestone: | Component: none
Version: trunk | Severity: medium
Keywords: | Lang:
Patch: | Platform:
--------------------+-------------------------------------------------------
src/pmc/handle.pmc was added to trunk at r39472 by whiteknight++ -
[io_rewiring] Merge the io_rewiring branch into trunk.
it caused test failures in manifest_tests and distro_tests.
kid51++ fixed the manifest_tests failures at r39509
this however resulted in other failures in codetest - some fixed by
barney++ at r39610.
The following failures still remain:
distro_tests:
{{{
# Failed test 'there are PMC files for all test files in t/pmc'
# at t/distro/test_file_coverage.t line 57.
# files in src/pmc but not in test dir:
# handle
# Looks like you failed 1 test of 3.
t/distro/test_file_coverage.t ..
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests
}}}
codetest:
{{{
t/codingstd/pod_syntax.t ....... 2/2
# Failed test 'Pod syntax correct'
# at t/codingstd/pod_syntax.t line 45.
# got: 'src/pmc/handle.pmc'
# expected: ''
# You should use podchecker to check the failed files.
# Looks like you failed 1 test of 2.
t/codingstd/pod_syntax.t ....... Dubious, test returned 1 (wstat 256,
0x100)
Failed 1/2 subtests
}}}
podchecker results in:
{{{
m...@mhj-desktop:~/parrot$ podchecker src/pmc/handle.pmc
*** ERROR: =over on line 15 without closing =back at line EOF in file
src/pmc/handle.pmc
src/pmc/handle.pmc has 1 pod syntax error.
}}}
As it stands at r39510 the file src/pmc/handle.pms is:
{{{
/*
Copyright (C) 2008, Parrot Foundation.
$Id: handle.pmc 39510 2009-06-11 12:51:08Z barney $
=head1 NAME
src/pmc/handle.pmc - IO Handle PMC
=head1 DESCRIPTION
This is the base-class for all IO-related PMCs.
=head2 Vtable Functions
=over 4
=cut
*/
#include "parrot/parrot.h"
#include "../src/io/io_private.h"
pmclass Handle provides Handle {
/* TODO: Consider encapsulating PIOHANDLE as a PMC type, for
subclassing */
ATTR PIOHANDLE os_handle; /* Low level OS descriptor */
VTABLE void init() {
Parrot_ex_throw_from_c_args(interp, NULL,
EXCEPTION_INVALID_OPERATION,
"Handle cannot be instantiated directly.");
}
VTABLE void init_pmc(PMC * init) {
Parrot_ex_throw_from_c_args(interp, NULL,
EXCEPTION_INVALID_OPERATION,
"Handle cannot be instantiated directly.");
}
}
/*
* Local variables:
* c-file-style: "parrot"
* End:
* vim: expandtab shiftwidth=4:
*/
}}}
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/751>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
