#751: test failures related to src/pmc/handle.pmc
--------------------+-------------------------------------------------------
 Reporter:  mikehh  |       Owner:  whiteknight
     Type:  cage    |      Status:  assigned   
 Priority:  major   |   Milestone:  1.3        
Component:  core    |     Version:  trunk      
 Severity:  medium  |    Keywords:             
     Lang:          |       Patch:             
 Platform:          |  
--------------------+-------------------------------------------------------

Comment(by whiteknight):

 I've been thinking about this issue since yesterday, and I think we're
 going about it all wrong. Instead of blindly following the test and
 creating a new t/pmc/handle.t test file, I say we fix the test to not
 require it.

 Handle is intended to be an abstract type, and should not be instantiated
 and used directly. Instead, it is inherited by other IO-related PMC types
 to provide a common base. As such, it's already tested as well as it is
 going to be in t/pmc/filehandle.t and t/pmc/stringhandle.t, and others. A
 test file t/pmc/handle.t has nothing to do: You can't create a Handle
 directly, and even if you could it's not usable for anything by itself.

 A far better solution to this issue is to create a blacklist of PMC types
 that do not need to have their own test file in t/pmc/*. This is how we
 can support the addition of more abstract PMC types in the future, if we
 choose to add more.

-- 
Ticket URL: <https://trac.parrot.org/parrot/ticket/751#comment:3>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets

Reply via email to