#1061: Lists of test files duplicated.
---------------------+------------------------------------------------------
Reporter: coke | Owner:
Type: cage | Status: new
Priority: minor | Milestone:
Component: testing | Version: trunk
Severity: medium | Keywords:
Lang: | Patch:
Platform: |
---------------------+------------------------------------------------------
We have lists of test files both in the root Makefile:
{{{
+EXTRA_TEST_FILES := \
+ t/compilers/pct/*.t \
+ t/compilers/pge/*.t \
+ t/compilers/pge/p5regex/*.t \
+ t/compilers/pge/perl6regex/*.t \
+ t/compilers/tge/*.t \
+ t/library/*.t \
+ t/tools/*.t
}}}
and in lib/Parrot/Harness/DefaultTests.pm:
{{{
@library_tests = qw(
t/compilers/pct/*.t
t/compilers/pge/*.t
t/compilers/pge/p5regex/*.t
t/compilers/pge/perl6regex/*.t
t/compilers/tge/*.t
t/library/*.t
t/tools/*.t
);
}}}
Some are similarly named, some are differently named.
This information shouldn't be duplicated in 2 locations. I recommend not
using the perl module to specify this via t/harness, but instead to
declare the lists solely in the Makefile and then combine them as
necessary if chunks of tests files are shared across test invocations.
If there's a special testing target we need, we can create a target for it
rather than adding another command line option to t/harness.
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1061>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets