#1061: Lists of test files duplicated.
---------------------+------------------------------------------------------
Reporter: coke | Owner: jkeenan
Type: cage | Status: assigned
Priority: minor | Milestone:
Component: testing | Version: trunk
Severity: medium | Keywords:
Lang: | Patch:
Platform: |
---------------------+------------------------------------------------------
Changes (by jkeenan):
* cc: allison (added)
Comment:
Replying to [comment:2 mikehh]:
> The @library_tests were added at r40512 by allison and this moved these
tests out of the core_tests and hence out of make fulltest.
Mike,
I discovered this just seconds before seeing your post:
{{{
$ svn blame lib/Parrot/Harness/DefaultTests.pm | grep library_tests
40512 allison @library_tests
40512 allison @library_tests,
40512 allison @library_tests
40512 allison @library_tests = qw(
40512 allison push @default_tests, @library_tests;
r40512 | allison | 2009-08-12 23:24:27 -0400 (Wed, 12 Aug 2009) | 4 lines
[build] Alter 'coretest' target so it only builds and tests the
core vm. Add a 'corevm' target as a subset of the 'all' target
that only builds the core vm. The default build target is still 'all'.
}}}
But, are you '''sure''' that Allison's revision pulls these tests out of
`make fulltest`? After all, if they're added to the list of default
tests, they'd still be run as part of `make test` and hence as part of
`make fulltest` -- correct?
> The EXTRA_TEST_FILES in root.in was my attempt to add these tests to
make fulltest and make cover. There is probably a better way to do this,
but I couldn't think of one at the moment.
Well, I'm a bit confused about the current state of
''config/gen/makefile/root.in'' in this respect. Once defined
`EXTRA_TEST_FILES` is used only once:
{{{
1599 # extra tests - tests run by make test but not by make fulltest or
make cover
1600 extra_tests : test_prep
1601 $(PERL) t/harness $(EXTRA_TEST_ARGS) $(EXTRA_TEST_FILES)
}}}
But that comment at line 1599 appears to be contradicted by other, older
code in this file. `extra_tests` is invoked as part of target `fulltest`:
{{{
1493 fulltest :
[snip]
1503 extra_tests \
}}}
... and also (I think) as part of `cover`:
{{{
2115 cover-extra: cover.dummy
2116 -...@make@ extra_tests
}}}
I believe that Allison's intent was to create a target which reduced the
running time of the most essential tests, without changing people's
expectations of what was to be run by `make test`. Did her revision have
a different, unintended result?
Seeking clarification,[[BR]]
kid51
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1061#comment:3>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
