#1049: [TODO] replace the value for $(MAKE) with the actual path
(config/inter/make.pm)
-----------------------+----------------------------------------------------
Reporter: doughera | Owner:
Type: bug | Status: new
Priority: normal | Milestone:
Component: configure | Version: 1.6.0
Severity: medium | Keywords:
Lang: | Patch:
Platform: |
-----------------------+----------------------------------------------------
Comment(by doughera):
Replying to [comment:1 jkeenan]:
> For reference, I am displaying relevant parts of configuration steps:
The key one is this (from root.in):
{{{
> config/gen/makefiles/root.in
>
> 572 # This is set to MAKE=$make if your $make command doesn't
> 573 # do it for you.
> 574 @make_set_make@
> 575 MAKE = @make_c@
}}}
This leads to silly things like this in the generated Makefile, where the
comment is clearly no longer accurate.
{{{
# This is set to MAKE=$make if your $make command doesn't
# do it for you.
#
MAKE = $(PERL) -e 'chdir shift @ARGV; system q{dmake}, @ARGV; exit $$? >>
8;'
}}}
As I noted in the original RT ticket:
The problem here is that most 'make' commands set the variable $(MAKE)
to refer to the calling program. For some unspecified reason, the patch
in r10027 changes that and uses the variable $(MAKE) to mean something
different (either make -C or a perl equivalent). I can't see how
redefining a built-in variable to mean something different is a good
idea. But it clearly was a deliberate change, so I'm not sure what to do.
The natural thing to do would be to call that variable MAKE_C. I can't
think of any fundamental reason why that wouldn't work.
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1049#comment:2>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
