#1049: [TODO] replace the value for $(MAKE) with the actual path
(config/inter/make.pm)
-----------------------+----------------------------------------------------
 Reporter:  doughera   |       Owner:  jkeenan 
     Type:  bug        |      Status:  assigned
 Priority:  normal     |   Milestone:          
Component:  configure  |     Version:  1.6.0   
 Severity:  medium     |    Keywords:          
     Lang:             |       Patch:          
 Platform:             |  
-----------------------+----------------------------------------------------

Comment(by jkeenan):

 That problem was addressed with an explicit assignment to `$(MAKE)` in the
 Makefile.
 {{{
 diff --git a/config/gen/makefiles/root.in b/config/gen/makefiles/root.in
 index 45236ee..5dff74e 100644
 --- a/config/gen/makefiles/root.in
 +++ b/config/gen/makefiles/root.in
 @@ -572,7 +572,8 @@ EXTRANCITHUNKS_SO   =
 $(DYNEXT_DIR)/extra_nci_thunks$(LOAD_EXT)
  # This is set to MAKE=$make if your $make command doesn't
  # do it for you.
  @make_set_make@
 -MAKE = @make_c@
 +MAKE = @make@
 +MAKE_C = @make_c@
 ...[as before]
 }}}
 I'm not sure why that solved the problem (`make fulltest` is now passing
 in this branch), but I do note that there was/is one use of
 `$PConfig{make}` inside ''lib/Parrot/Test.pm'':
 {{{
  655 sub _run_test_file {
  656     my ( $func, $code, $expected, $desc, %extra ) = @_;
  657     my $path_to_parrot = path_to_parrot();
 ...
  699     if ( $args =~ s/--run-exec// ) {
  700         $run_exec = 1;
  701         my $pbc_f = per_test( '.pbc', $test_no );
  702         my $o_f = per_test( '_pbcexe' . $PConfig{o}, $test_no );
 ...
  722             if ( -e $o_f ) {
  723                 run_command(
  724                     qq{$PConfig{make} EXEC=$exec_f exec},
  725                     CD     => $path_to_parrot,
  726                     STDOUT => $out_f,
  727                     STDERR => $out_f
  728                 );
 }}}

-- 
Ticket URL: <https://trac.parrot.org/parrot/ticket/1049#comment:5>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets

Reply via email to