#1215: Factor out Duplicated Code in vivify/fetch opcodes
-----------------------+----------------------------------------------------
Reporter: chromatic | Owner: soh_cah_toa
Type: cage | Status: assigned
Priority: minor | Milestone:
Component: core | Version: 1.7.0
Severity: low | Keywords: ops newbie
Lang: | Patch:
Platform: all |
-----------------------+----------------------------------------------------
Comment(by cotto):
A couple things comments: First, please include the generated core_ops.c
file in your diff. If there's no diff, you forgot to rebootstrap the ops.
Run make bootstrap-ops or just ./ops2c --core and the core_ops file will
be regenerated. The attached patch misspells "BEGIN_OPS_PREAMBLE" and
doesn't build.
Second, the patch incorrectly changes some calls to VTABLE_*_pmc_keyed_*.
That part of the code doesn't need any changes and causes the build to
fail with a bootstrapped core_ops file.
Thank you for working on this.
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1215#comment:8>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
