On Thu, 2007-02-15 at 17:48 +0100, Jim Meyering wrote: > Otavio Salvador <[EMAIL PROTECTED]> wrote: > > Jim Meyering <[EMAIL PROTECTED]> writes: > > > >> Hello, > >> > >> I'm preparing a patch that makes the build warning free, > >> and found some unused functions in libparted/labels/fdasd.c. > >> Here they are: > >> > >> (fdasd_partition_type): > >> (fdasd_write_vtoc_labels): > >> (fdasd_change_volser): > >> (fdasd_check_volser): > >> (fdasd_reread_partition_table): > > > > On this specific case I think that would be better to leave fdasd out > > of your patch. We have a fix on Debian package that needs to be ported > > (from 1.7 release) and then dasd could be cleaned up. > > I'm easy. > But you say "fdasd", then "dasd". I presume the latter should be "fdasd".
We say 'dasd' when we refer to zSeries disk support in general. The actual source files are fdasd, vtoc, something else probably. > However, are you worried about the risk of a merge conflict? > Unless it's more than a strategic fix, they shouldn't be changing dead code I think the concern is more about possibly needing those unused functions in the Hercules environment, but not on real zSeries hardware. We won't know until I or someone else sits down and figures out parted on hercules. -- David Cantrell <[EMAIL PROTECTED]> Red Hat / Westford, MA
signature.asc
Description: This is a digitally signed message part
_______________________________________________ parted-devel mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/parted-devel
