Wanted to let everyone know what I'm planning for parted-1.8.3. We've had a lot going on recently and I think it's important to stick by the plan we had a while back now for the difference between stable and edge branches.
That said, my plan for 1.8.3 is to incorporate the following kinds of
patches from edge:
- Bug fixes (memory leaks, actual crashes, etc)
- Patches to make gcc -Wall pass cleanly
- Library cleanups (e.g., adding const where necessary)
What am I leaving out?
- Large whitespace changes
- The updates to the autotools infrastructure
- Other non-functional changes
I really don't want 1.8.x to continue forever, so I'm trying to make it
change as little as possible. The majority of our updates recently have
been to infrastructure and those are best kept in 1.9.x. The items I'm
leaving out will make it easy for those distributions that want to
backport fixes from 1.8.3 to an even older release of parted (I speak
from personal experience too having to maintain parted-1.6.19 in
RHEL-4).
Are there any library cleanups and bug fixes that are in progress for
edge that are good candidates for 1.8.3? The one I can think of now is
what Jim is working on to fix the 2048-byte sector problem. Anyone else
have anything of note?
Attached is a list of commits I will be cherry-picking from edge to
stable (in addition to the fix Jim is working on above).
Thoughts in general?
--
David Cantrell <[EMAIL PROTECTED]>
Red Hat / Westford, MA
commit f17009aed96034ed616584b7ef574afe1c888244
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Thu Mar 8 01:05:33 2007 +0100
Don't use deprecated mktemp, to avoid linker warning
* libparted/tests/common.c (_create_disk): Rewrite to
use mkstemp instead.
commit 8688ee8a013beb784677c9a0f8dd8bdd7630900b
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Thu Mar 8 01:04:44 2007 +0100
* libparted/tests/label.c: Plug a trivial leak.
commit 3e3eda0ef42443fdec9336bb03ec00865686f372
Author: Debarshi Ray <[EMAIL PROTECTED]>
Date: Thu Mar 8 01:48:30 2007 +0530
Replaced [f]printf with fput[c|s] globally.
commit 78a2b090920ca7c01b282869162fa020390915c1
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Wed Mar 7 19:39:56 2007 +0100
libparted/unit.c: constify interfaces
* include/parted/unit.h (PED_UNIT_LAST):
* libparted/unit.c (ped_unit_get_size):
(ped_unit_format_custom_byte, ped_unit_format_byte):
(ped_unit_format_custom, ped_unit_format, ped_unit_parse):
(find_suffix, parse_chs, clip, geometry_from_centre_radius):
(ped_unit_parse_custom):
commit faf87a7fab1abeb8af44aa72700a25324efd927f
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Wed Mar 7 19:27:18 2007 +0100
Declare some static arrays to be "const".
* libparted/labels/dos.c (MBR_BOOT_CODE):
* libparted/labels/efi_crc32.c (crc32_tab):
* libparted/labels/pc98.c (MBR_BOOT_CODE):
* libparted/labels/vtoc.c (EBCtoASC, ASCtoEBC):
commit 0915771a4689800e18246b15d1a681cab750bba3
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Wed Mar 7 18:56:21 2007 +0100
tests/label: Don't dereference NULL if open fails.
* libparted/tests/label.c (START_TEST): Return right away if
ped_device_get returns NULL.
commit cb77063c26281dae2dbce6079819c4aad4e15b15
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Wed Mar 7 18:17:00 2007 +0100
Add "const" to parameters in these public interfaces.
* libparted/disk.c (ped_disk_check):
(ped_disk_get_primary_partition_count):
(ped_disk_get_last_partition_num, ped_partition_print):
(ped_disk_print):
(ped_partition_print): Also declare to be "static".
This is ok, since the function is referenced only from this file.
* include/parted/disk.h: Update their prototypes.
commit cc1955e39202f9ff5ecf9f3bf874af1b85a737aa
Author: David Cantrell <[EMAIL PROTECTED]>
Date: Tue Mar 6 17:19:31 2007 -0500
start_pos is a PedSector, not a PedGeometry.
commit 51e774269002a7a9c0aecf497d4d98486c918918
Author: David Cantrell <[EMAIL PROTECTED]>
Date: Tue Mar 6 11:18:20 2007 -0500
Preserve starting sector for primary NTFS 3.1 partitions (Windows Vista)
when modifying the DOS disk label. NTFS 3.1 partitions do not start on
the 2nd head of the 1st cylinder at the beginning of the drive.
commit 40bfba3a317f33e7bc55fdd8cd5073ac69ae280a
Author: David Cantrell <[EMAIL PROTECTED]>
Date: Fri Mar 2 13:20:28 2007 -0500
Patched parted.8 man page to show partition names apply to GPT disk labels
as well as Mac and PC98 disk labels.
commit 5330d232f97619b39277bd46f8858bb41a8f1541
Author: Debarshi Ray <[EMAIL PROTECTED]>
Date: Tue Mar 6 20:47:58 2007 +0530
Replaced [f]printf with fput[c|s] in
libparted/fs/ext2/ext2_block_relocator.c.
commit f4a46701638355a80e75909315878b3b7237b6b5
Author: Debarshi Ray <[EMAIL PROTECTED]>
Date: Tue Mar 6 15:57:24 2007 +0530
Defined a dummy '_dump_history' function in parted/ui.c when Readline is
absent. Thanks to Jim Meyering for the suggestion.
commit 7ca20fbca15e89d8d40c33d11917c6969f1ed403
Author: Debarshi Ray <[EMAIL PROTECTED]>
Date: Tue Mar 6 14:37:25 2007 +0530
Fixed parted/ui.c to incorporate signal handlers for systems lacking
'sigaction', 'SA_SIGINFO', and other constants in signal.h.
commit ce3810b4372764154b71a299c3e90eb08a610a46
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Mon Mar 5 22:44:38 2007 +0100
Undo part of the dos.c constification.
* libparted/disk.c: The sole parameter of ped_disk_type_register
and ped_disk_type_unregister must *not* be const.
* libparted/labels/dos.c (msdos_disk_type): Likewise for the
corresponding static struct in dos.c, since those functions modify
the struct. This didn't show up at compile time due to casts.
* include/parted/disk.h: Update prototypes, too.
commit 3011e1809a1935f576a5ec80681cc5fcf94cd262
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Mon Mar 5 22:07:23 2007 +0100
Hide two unnecessarily-"extern" functions.
* libparted/labels/mac.c (mac_alloc): Declare static.
* libparted/labels/dos.c (raw_part_parse): Declare static.
commit f0c8fc255dbdefea2f5c79ae100f89c852952312
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Mon Mar 5 15:37:25 2007 +0100
* libparted/labels/dos.c: Complete constification of this file.
* libparted/disk.c (ped_disk_type_register): Make the sole
parameter "const", so that caller's argument may be "const".
(ped_disk_type_unregister): Likewise.
commit a3f971d08ff676bd515da2830acfddd3753d5b6e
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Mon Mar 5 14:44:58 2007 +0100
* include/parted/disk.h (struct _PedDiskOps) [write]: Change
parameter type to be "const".
commit 6b0d9c51985ae48af05250bd50600f387ba7ff8d
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Mon Mar 5 14:37:39 2007 +0100
Begin making libparted/labels/*.c const-correct.
For an introduction, see
http://mail-archive.com/[email protected]/msg00930.html
In particular, I've used a const-adding case in mac.c to work around
the current, inconsistent semantics of mac_write.
commit 72d1a0c4e574c528e30b1e104490772530eedcb1
Author: Debarshi Ray <[EMAIL PROTECTED]>
Date: Tue Feb 27 04:02:44 2007 +0530
Fixing libparted/arch/gnu.c to remove build-time errors.
commit 7a46b70e5ecc0b1eb97e87158e2ca0816d63214e
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Sun Feb 25 18:44:30 2007 +0100
Avoid a gcc format warning:
* debug/clearfat/clearfat.c (_do_help): Use fputs, not printf.
commit 40758f1bd909f927e81f9a523fc4169e18572eec
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Sun Feb 25 18:44:30 2007 +0100
* libparted/tests/label.c: Fail if _create_disk returns NULL.
Make global and functions static.
* libparted/tests/common.c (_create_disk): Handle fopen failure.
Handle fclose failure.
commit a7975b69a52675f8a1ef346d4b5ebf994200c88e
Author: Anant Narayanan <[EMAIL PROTECTED]>
Date: Fri Feb 23 16:18:31 2007 +0530
Fix memleaks. Patch thanks to Mike Hommey
commit 9d4a4289659625ef143e8c74a26654a7c4da2906
Author: Debarshi Ray <[EMAIL PROTECTED]>
Date: Mon Feb 19 09:09:44 2007 +0530
Cleaning up nested structs & unions.
commit 4529f6625622b459975c59921f4360afe6b7eb5c
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Fri Feb 16 15:55:40 2007 +0100
Avoid compiler warnings with gcc -Wall -Wshadow.
* libparted/arch/linux.c (init_ide): Add missing "break" at end of
final case: stmt.
Add "default:" in the same switch to avoid a compiler warning.
* libparted/fs/fat/bootsector.c (fat_boot_sector_analyse): Likewise.
* libparted/fs/fat/resize.c (ask_type): Likewise.
* libparted/fs/fat/traverse.c (fat_dir_entry_set_first_cluster):
Likewise.
* debug/clearfat/clearfat.c (_calc_fat_entry_offset): Likewise.
* parted/parted.c (_timer_handler): Cast time_t values to "int"
to agree with %d printf format.
(g_timer): Rename file-scoped global from shadowed "timer".
Update all uses of the global.
(version_msg): Remove decl of unused global.
* parted/ui.c (current_exception_opt): Remove decl of unused global.
* libparted/filesys.c (ped_file_system_close): Remove unused label.
* libparted/unit.c (parse_chs): Likewise.
* libparted/debug.c (ped_assert): Use "int" as type of backtrace
return value, not size_t.
* libparted/fs/reiserfs/reiserfs.c (reiserfs_check):
Guard declaration of local with #ifdef HAVE_REISERFS_FS_CHECK,
since it's used only in a similarly-guarded block.
(reiserfs_fs_check): Likewise for this file-scoped global.
Avoid warnings about unused file-scoped global variables.
* libparted/fs/hfs/hfs.h (hfs_type, hfsplus_type): Remove these
declarations of file-scoped static variables.
* libparted/fs/hfs/hfs.c: Put them here, instead.
* libparted/fs/fat/table.c (_test_code_active): Remove unused function.
* libparted/arch/linux.c: Add casts to avoid performing
pointer arithmetic on "void *" pointers.
* libparted/fs/hfs/file_plus.c (hfsplus_file_read):
Don't do pointer arithmetic on a "void *" pointer.
(hfsplus_file_write): Likewise.
* libparted/fs/fat/count.c (flag_traverse_dir): Move decl of
unused local into #if-0'd block where it is referenced.
(print_chain): Guard definition with #ifdef PED_VERBOSE,
since the sole use of this function is guarded the same way.
* libparted/fs/amiga/amiga.c: (_amiga_valid_block_id):
Remove unused function.
(_amiga_get_bstr): Likewise.
(_amiga_set_bstr): Likewise.
Remove unused labels and/or declarations of unused variables.
* parted/ui.c (_readline): Likewise.
* libparted/cs/constraint.c (_constraint_get_canonical_start_range):
Likewise.
* libparted/cs/geom.c (ped_geometry_read): Likewise.
* libparted/fs/amiga/apfs.c (_generic_apfs_probe): Likewise.
* libparted/fs/ext2/ext2_mkfs.c (ext2_mkfs_write_meta): Likewise.
* libparted/disk.c: Likewise.
* libparted/fs/hfs/hfs.c: Likewise.
* libparted/fs/fat/fat.c: Likewise.
* libparted/fs/fat/clstdup.c: Likewise.
* libparted/fs/fat/calc.c: Likewise.
* libparted/fs/ext2/ext2.c: Likewise.
* libparted/fs/amiga/affs.c: Likewise.
* libparted/fs/amiga/asfs.c: Likewise.
* libparted/labels/aix.c: Likewise.
* libparted/labels/sun.c: Likewise.
* libparted/labels/pc98.c: Likewise.
* libparted/labels/mac.c: Likewise.
* libparted/labels/dos.c: Likewise.
* libparted/labels/loop.c (loop_alloc): Likewise.
* libparted/labels/gpt.c: Likewise.
* libparted/labels/dvh.c (dvh_alloc): Likewise.
(dvh_read) [!DISCOVER_ONLY]: Add "default:" in a switch.
* libparted/labels/fdasd.c (fdasd_reread_partition_table):
Remove decl of unused local(s).
(fdasd_get_partition_data): Likewise.
(fdasd_partition_type): Remove unused function.
(fdasd_write_vtoc_labels): Likewise.
(fdasd_change_volser): Likewise.
(fdasd_check_volser): Likewise.
(fdasd_reread_partition_table): Likewise.
Signed-off-by: Jim Meyering <[EMAIL PROTECTED]>
commit cbf5b4da095637e18ab6f2b8a52a506a4126845b
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Thu Feb 15 16:05:17 2007 +0100
* libparted/labels/rdb.c (amiga_read): Remove decl of unused local(s).
Signed-off-by: Jim Meyering <[EMAIL PROTECTED]>
commit 3f3af4affe2ee037620c717acc7d3fc84422574c
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Thu Feb 15 15:56:23 2007 +0100
* libparted/labels/bsd.c (bsd_partition_new): Remove unused label.
Signed-off-by: Jim Meyering <[EMAIL PROTECTED]>
commit 74eb62c50d7a6107f7c9dcb5273060f20da990b8
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Thu Feb 15 15:53:44 2007 +0100
* libparted/labels/dasd.c: Remove unused labels and declarations
of unused variables.
Signed-off-by: Jim Meyering <[EMAIL PROTECTED]>
commit 93ca20d8aebd0d04dbb00b86a2903c992e59a96b
Author: Debarshi Ray <[EMAIL PROTECTED]>
Date: Fri Feb 16 10:10:17 2007 +0530
Fix the style of typedef, enum, struct and __attribute__ ((packed)).
commit f4022a35faf01c5286ab5b44bce080e80d310099
Author: Debarshi Ray <[EMAIL PROTECTED]>
Date: Thu Feb 15 10:25:41 2007 +0530
Deprecating ped_[register|unregister]_disk_type in favour of
ped_disk_type_[register|unregister].
commit 3965965b3413df11d6306704478490f6e5b72549
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Tue Feb 13 22:51:56 2007 +0100
Use lighter-weight fputs and putchar in place of printf, when possible.
* parted/ui.c (wipe_line, _dump_history, reset_env):
(sigsegv_handler, sigfpe_handler, sigill_handler, _readline):
(help_msg, interactive_mode, non_interactive_mode): Use puts,
fputs, and putchar in place of printf, when possible.
(reset_env): Correct misleading indentation.
(wipe_line): Split a long string.
Signed-off-by: Jim Meyering <[EMAIL PROTECTED]>
commit 4ae6903525e60202efa78ebec336d1bb2c3bb6b4
Author: Debarshi Ray <[EMAIL PROTECTED]>
Date: Wed Feb 14 22:19:42 2007 +0530
Fixed the copyright notices.
commit 69b733fcedc80d7192fb98c2ade006938c6d58f8
Author: Debarshi Ray <[EMAIL PROTECTED]>
Date: Wed Feb 14 21:39:57 2007 +0530
Cleaned up the formatting of AUTHORS.
commit d29c917bf4a22a084deecf769346f030b87e0eb8
Author: Debarshi Ray <[EMAIL PROTECTED]>
Date: Wed Feb 14 20:25:12 2007 +0530
Tidying up the formatting and comments in linux_swap.c.
commit 951e82fc0c102aa8187cf19de49c9f504eaa60f6
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Tue Feb 13 21:02:08 2007 +0100
Don't define _GNU_SOURCE manually.
It's better not to define _GNU_SOURCE manually.
By using AC_GNU_SOURCE, you get the definition in exactly one place:
in config.h. I verified that each affected file also includes config.h.
Don't define _GNU_SOURCE manually.
* configure.ac: Use AC_GNU_SOURCE instead.
* libparted/arch/gnu.c: Remove definition of _GNU_SOURCE.
* libparted/arch/linux.c: Likewise.
* libparted/device.c: Likewise.
* parted/table.c: Likewise.
* parted/table.h: Likewise.
Signed-off-by: Jim Meyering <[EMAIL PROTECTED]>
commit 2d2e20fc366c08519fdac33d74686da87d8291f5
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Tue Feb 13 17:10:18 2007 +0100
Remove some #ifdefs
Remove some #ifdefs.
* parted/table.c (L_): define.
Remove in-function #ifdefs; use L_(str) instead.
Signed-off-by: Jim Meyering <[EMAIL PROTECTED]>
commit f38cb2091e5f9cd300b4bc0aa93138c205d34135
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Tue Feb 13 17:08:35 2007 +0100
* libparted/labels/fdasd.c (GETARG): Remove unused definition.
A tiny change...
Signed-off-by: Jim Meyering <[EMAIL PROTECTED]>
commit 64f61abbcaefe060433196e323eba251bfc6e17e
Author: Jim Meyering <[EMAIL PROTECTED]>
Date: Mon Feb 12 23:35:30 2007 +0100
Compile warning-free with "gcc -Wall -Wshadow".
Hello,
I find that keeping code warning-free (wrt gcc -Wall -Wshadow)
makes it easier to avoid certain classes of bugs.
Compiling with gcc -Wall -Wshadow evoked a few warnings
on a Debian/unstable system. Here are patches to fix those:
* libparted/exception.c (default_handler): Rename parameter "ex"
to "e", to avoid shadowing file-scoped global.
* libparted/fs/linux_swap/linux_swap.c (_generic_swap_probe): Add a
"can't happen" (with current callers) "default: goto error" clause
in a switch to avoid a may-be-used-uninitialized warning.
(_generic_swap_clobber): Likewise.
* libparted/fs/hfs/reloc_plus.c (hfsplus_pack_free_space_from_block):
Rename local variable "div" to "divisor", to avoid shadowing
the function in <stdlib.h>.
* libparted/fs/hfs/reloc.c (hfs_pack_free_space_from_block): Likewise.
* libparted/fs/hfs/cache.c (hfsc_cache_add_extent): Rename parameter
"index" to "ref_index" to avoid shadowing the <string.h> function.
* libparted/labels/sun.c (sun_partition_enumerate): Rename local
variable "i" to "j", to avoid shadowing another local.
Signed-off-by: Jim Meyering <[EMAIL PROTECTED]>
commit 92f00c9a4b6669954aa8689c5963c52ceaefdf57
Author: Riccardo Setti <[EMAIL PROTECTED]>
Date: Mon Feb 12 13:24:29 2007 +0100
Added a pkgconfig file for libparted, adjusted Makefile.am and configure.ac
for reflect the canges
modified: Makefile.am
modified: configure.ac
new file: libparted.pc.in
commit 760e6decef7aac12aada62c3185e83506fcb5d47
Author: Debarshi Ray <[EMAIL PROTECTED]>
Date: Wed Jan 31 02:01:43 2007 +0530
Renaming PARTITION_EXT to PARTITION_DOS_EXT in MSDOS disk-label code, to
maintain similarity with Linux v2.6.18.2
commit 98a53fd115ca012edf226525b8d4be628454f99e
Author: Debarshi Ray <[EMAIL PROTECTED]>
Date: Wed Jan 17 18:56:46 2007 +0530
Enable support for swsusp partitions, and the ability to differentiate
between old and new versions of linux-swap partitions. Changed the swap_init
signature and removed extra ped_geometry_read from _swap*_open.
commit f58467190721c7d29b2d07c1567cdd90633f1996
Author: Debarshi Ray <[EMAIL PROTECTED]>
Date: Tue Jan 16 23:13:09 2007 +0530
Synchronize the linux-swap (new version) header according to the Linux
kernel sources.
commit 8cc182e1919144ecaede5b95983b6528017a78ac
Author: Debarshi Ray <[EMAIL PROTECTED]>
Date: Tue Jan 16 22:41:47 2007 +0530
cb6ca73be06f360308e6a2fccb7142ed8175af29 continued.
commit cb6ca73be06f360308e6a2fccb7142ed8175af29
Author: Debarshi Ray <[EMAIL PROTECTED]>
Date: Tue Jan 16 06:43:36 2007 +0530
Add stdint.h stdlib.h & string.h to include/parted/parted.h and remove them
from other files.
commit 21dc308fe0829e12d55fba0e6f75063cf7bf651a
Author: Debarshi Ray <[EMAIL PROTECTED]>
Date: Sun Jan 14 21:06:58 2007 +0530
Synchronise manual page and --help documentation.
signature.asc
Description: This is a digitally signed message part
_______________________________________________ parted-devel mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/parted-devel
