On Fri, May 15, 2009 at 03:54:35PM +0200, Jim Meyering wrote: > Joel Granados Moreno wrote: > > Some stuff that I worked on today: > > > > 1. Make dmraid default. > > 2. Little change to make the syntax check work. > > 3. Move the partition_check from disk.c to the label files. > > Does #3 fix a bug? Haven't looked carefully yet.
Not really. It just organizes the code in a modular way. Instead of having label specific code in disk.c, we put everything in the label files (like its suppose to be). > If not, would you please target "next" instead? Sure. Lets see what cherrypicking that commit will do to next. Hope its not too different. > > On that branch there are new files, pt-tools.[ch] Great!!! I'll put the code here. I'll probably do a cherry pick of the current patch and then do another patch to put everything in pt-tools.[ch] > for just that purpose. There is such a blatant need > for factorization that I fear if we do anything significant > on master, we'll waste an inordinate amount of time merging > with the factorization changes I've begun on "next". > > > I know that patch 3 introduces repeated code in two files. I was going > > to address this by introducing a new file to the libparted/labels/ > > directory called common.c or label_common.c or something like that. > > Where one can put stuff like that repeated function without compromising > > the modularity of the label abstraction. > > > > As always, comments a greatly appreciated. > > > > Regards. > > > > Joel Andres Granados > > Brno, Czech Republic, Red Hat. > > > > _______________________________________________ > > parted-devel mailing list > > [email protected] > > http://lists.alioth.debian.org/mailman/listinfo/parted-devel Thx for the reviews!! -- Joel Andres Granados Brno, Czech Republic, Red Hat. _______________________________________________ parted-devel mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/parted-devel
