On Thu, Jan 17, 2013 at 11:56:33PM -0500, Phillip Susi wrote: > The following series reintroduces the ability to resize partitions to > parted. They build on some previous work by Petr Uzel and the new > resize BLKPG ioctl options in recent kernels. The new acting command > is resizepart, and a hidden dummy command "resize" has been added > for backward compatability with scripts that still use the removed > command. The resize command now just errors out complaining that > it has been removed. This is to avoid being auto completed to the > new resizepart command, which only moves the end point of a partition > without affecting the filesystem it contains. The resizepart command > will use the new BLKPG ioctl to update the kernel partition table > if the partition is in use. This allows expanding ( or even shrinking > in the case of btrfs ) of a partition while it is mounted, when used > in conjunction with the approrpiate external fs utility to modify > the size of the filesystem.
I've just skimmed these, so don't take these comments as absolute :) I like the direction it is going, a few thoughts I had: * compare to known kernel version that include the new ioctl to enable/disable it. * watch out for mixing spaces/tabs -- I prefer spaces, but at the least it should be consistent. * on GPT we need to make sure they can't extend it over the top the the gpt backup at the end of the disk. This may happen already, I haven't looked that deep. * vol_name variable isn't being setup. * I generally worry about operations on active partitions causing problems. -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgp4VgXwhulxW.pgp
Description: PGP signature
