-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 4/1/2013 4:57 PM, Brian C. Lane wrote: > I've just skimmed these, so don't take these comments as absolute > :) I like the direction it is going, a few thoughts I had: > > * compare to known kernel version that include the new ioctl to > enable/disable it.
And do what instead? I think the current error message is informative enough. > * watch out for mixing spaces/tabs -- I prefer spaces, but at the > least it should be consistent. Is there anywhere specific you had in mind? It's a bit of a pain since parted already is inconsistent in this regard, so I'm never sure which one I should be using. > * on GPT we need to make sure they can't extend it over the top the > the gpt backup at the end of the disk. This may happen already, I > haven't looked that deep. I'm pretty sure GPT already does this but it's worth double checking. > * vol_name variable isn't being setup. Good catch. I'm not even sure why that field is there since it is unused. I'll probably just remove it. > * I generally worry about operations on active partitions causing > problems. Hence the "are you sure?" warning. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRWz0XAAoJEJrBOlT6nu75s/EIAJr6aqToS/mjinyR35DseiP4 lZkM0qX30u7JmxVf9IJl3qSntwmd5i5/8eoz6PDNhlpDwyyIxGIKMh+Ue8VJ4Gzv TQPe925zxhgGOkL9odqcUvvYosdk69jQiDkPD5ZkBPzpPwqseBfLT1S0Qt9KkM34 CTHI2Tzpsp+8hHnf8cr/bHwtwJj+kF8oyVc8gM7B1C4IIH/jcBuvSbll0AruA6Ud BRh2swDixlSlqXIoPjTHqPN8MDL9Aa0u6ZXg87Nz/J0FNLVF+yRFPRYvm8/65VdD bqcIHr2xfkGRX/dc9VPlan6TA5b9FsBsFV8oLM4tCNc/TTU26kc/0gdKefUB5uo= =2UDT -----END PGP SIGNATURE-----
