Hi,
I thought that the TCP code that defaults to "127.0.0.1" was a good
idea, but in fact it gets in the way of allowing it to bind to all
interfaces (which is also done by using "" as the IP).
Other options would have added command line switches and complications,
this is the easiest option. It may require updating the man page to make
it clear (although it does say tcp mode is insecure)
This is useful for laptops and roaming, were the interfaces may come and
go and you do not want to lose your sessions or have to setup tunnels by
hand. (MS Windows boxes for example).
So the security aspects (tunnels or firewall rules) are still left to
the user (for now...)
Please consider applying (at least one regular user).
Cheers
Antoine
diff -ur parti-all-0.0.7-pre-vanilla/xpra/scripts/server.py parti-all-0.0.7-pre/xpra/scripts/server.py
--- parti-all-0.0.7-pre-vanilla/xpra/scripts/server.py 2009-04-03 08:29:09.000000000 +0200
+++ parti-all-0.0.7-pre/xpra/scripts/server.py 2009-04-28 23:39:42.669819625 +0200
@@ -138,8 +138,6 @@
if ":" not in spec:
parser.error("TCP port must be specified as [HOST]:PORT")
(host, port) = spec.split(":", 1)
- if host == "":
- host = "127.0.0.1"
listener = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
listener.bind((host, int(port)))
return listener
_______________________________________________
Parti-discuss mailing list
[email protected]
http://lists.partiwm.org/cgi-bin/mailman/listinfo/parti-discuss
