Hi Nathaniel,
I was looking at the changes whilst rebasing my patches on mainline and
I've got a few questions:
1)
def draw(self, x, y, width, height, rgb_data):
assert len(rgb_data) == width * height * 3
(my_width, my_height) = self.window.get_size()
gc = self._backing.new_gc()
self._backing.draw_rgb_image(gc, x, y, width, height,
gtk.gdk.RGB_DITHER_NONE, rgb_data)
self.window.invalidate_rect(gtk.gdk.Rectangle(x, y, width, height),
False)
my_width and my_height aren't used, lint told me ;)
2) As mentionned in the other email, can you please merge this patch:
http://xpra.devloop.org.uk/patches/v0.0.8pre/mswindows-move-eventcode.patch
This really seems like a reasonable thing to do and would massively
reduce the amount of rebasing I have to do to keep win32 support in sync.
Please, please, please.
3) xvfb switch:
xvfb = subprocess.Popen(["Xvfb-for-Xpra-%s" % display_name,
display_name,
"-auth", xauthority,
"+extension", "Composite",
# Biggest easily available monitors are
# 1920x1200. This is 1920*2 x 1920:
"-screen", "0", "3840x1920x24+32",
"-once"],
executable="Xvfb")
Did you test this?
executable="Xvfb" should be opts.xvfb surely?
Also AFAIK, this does not allow you to specify arguments to Xvfb (or
Xvnc), like: --xvfb="Xvnc --PasswordFile=blah"
4) Still some unused imports, ie: xpra/scripts/server.py
And "from wimpiggy.error import *" is making lint shout at me. :(
Anyway, I've rebased my tree and the updated patches are in the same
place. I will update the debian/ubuntu repositories shortly.
Cheers
Antoine
_______________________________________________
Parti-discuss mailing list
[email protected]
http://lists.partiwm.org/cgi-bin/mailman/listinfo/parti-discuss
