[snip] >> 3) xvfb switch: >> xvfb = subprocess.Popen(["Xvfb-for-Xpra-%s" % display_name, >> display_name, >> "-auth", xauthority, >> "+extension", "Composite", >> # Biggest easily available monitors are >> # 1920x1200. This is 1920*2 x 1920: >> "-screen", "0", "3840x1920x24+32", >> "-once"], >> executable="Xvfb") >> >> Did you test this? >> executable="Xvfb" should be opts.xvfb surely? >> Also AFAIK, this does not allow you to specify arguments to Xvfb (or >> Xvnc), like: --xvfb="Xvnc --PasswordFile=blah" > > Err, doh. Yeah, apparently half the patch got lost somewhere... maybe > I somehow reverted xpra/scripts/server.py before committing? Anyway, > now committed and tested. > > And I'm a bit confused about the complaint about passing arguments, > because one of the things I disliked about your patch is that it > didn't allow passing arguments :-). But yes, the version in mainline > supports passing arguments.
Good, I'll rebase on that. (mine allowed that too so you're not the only one sending the wrong thing!) >> 4) Still some unused imports, ie: xpra/scripts/server.py > > You mean the 'import time'? Fixed. (And I swear I did this before > too... oh well.) > >> And "from wimpiggy.error import *" is making lint shout at me. :( > > Okay, like I said I don't think it matters much at this point, so send > a patch :-). Cool, will do when I get some free time. Antoine > (If I did it I'd probably be too lazy to look up exactly > which files reference 'trap', which reference 'XError', and which > reference both, and then you'd just end up sending me a patch > complaining about unused variables anyway, so this way seems simpler.) > > -- Nathaniel _______________________________________________ Parti-discuss mailing list [email protected] http://lists.partiwm.org/cgi-bin/mailman/listinfo/parti-discuss
