Perfect :) I implemented the changes you recommended and checked that things work fine in bash, things look good on my machine (bash 4.4.20). Unfortunately, I have not made a transition to zsh / fish and I have never written any scripts for these, so it would take me a large amount of time to implement the same fixes for these - I would need to go through zsh / fish tutorials first, I see there are a few differences compared with bash from your scripts.
I will mail the changes now, I think the best option for zsh / fish would be if somebody else with good experience of these could port the bash solution. On Mon, Mar 30, 2020 at 9:38 AM Reed Wade <[email protected]> wrote: > > > So do you want me to create a new commit on top of the old one fixing > > the things you mention, and send it again? :) Or did you take care of > > pushing something you like better already? > > You should commit amend your changes and send it back as a V2 patch to > review :)
