Hi, Just trying to get some overview, is the patch 'validated' and merged in the code, or if not, what actions should I take from my side?
Cheers, JR On Fri, Apr 10, 2020 at 5:39 PM J Rt <[email protected]> wrote: > > What do you think about this? Should this be merged in master or not? > I am slightly reluctant to start 'messing up' with IFS in all the > codebase, I would be afraid to introduce bugs etc. > > On Wed, Apr 8, 2020 at 2:05 PM J Rt <[email protected]> wrote: > > > > No wories :) . > > > > I guess that putting local on IFS everywhere may solve the problem, > > but I had been playing a bit around without managing to get it to > > work. Guess I was missing an IFS somewhere. > > > > > > On Tue, Apr 7, 2020 at 3:49 PM Reed Wade <[email protected]> wrote: > > > > > > Hello back ! > > > > > > Sorry for big delay, Migadu got problems with imap access cause of > > > recent events. > > > > > > > - the version I sent last time works. > > > > > > cool ! > > > > > > > - the version with the local var taken away and the "" protection works: > > > > > > cool ! > > > > > > > _append_to_compreply () { > > > > local IFS=" " > > > > for word in "$(_sort_entries_string "$1")"; do > > > > COMPREPLY+=($word) > > > > done > > > > } > > > > > > > > - this does not work (with uncommented IFS it works as shown on the > > > > previous point), so I think the IFS var is needed. : > > > > > > > > bla bla bla > > > > > > Aha yup. I just discovered some days ago bash actualy use something > > > called "dynamic scopes". In short, if a var is define outside of the > > > scope, bash update this variable value. Except if "local" is used ofc. > > > > > > Is it possible to add "local IFS" where needed ? This will make the > > > _append_to_compreply IFS useless right ?
