Get a bit the same feeling. Sent a small patch a few months ago. No
idea what its status is now. Would have been much easier to track the
status with a fork / pull request / issues workflow in my opinion. The
result is that I will probably not try to participate more here in the
future :( .

On Mon, May 25, 2020 at 1:05 PM Tobias V. Langhoff <[email protected]> wrote:
>
> I don't participate much on this mailing list, but several years back
> I sent a couple of very minor patches to an import script I wrote in
> 2014. I never received any reply, and sent a reminder (and an updated
> patch to resolve a merge conflict), but again I never heard anything.
> I don't even remember how many years ago this was, probably around
> 2017. I could search my email archive to find out, but that's pretty
> clunky, and honestly I don't care anymore.
>
> On Sun, May 24, 2020 at 5:49 PM Rémi Lapeyre <[email protected]> wrote:
> >
> >
> > > Le 22 mai 2020 à 03:48, Nathan Lilienthal <[email protected]> a écrit :
> > >
> > > I think one of the main issues here is that people hate email. I'm not
> > > sure how to solve this, but it is desperately in need of a solution.
> > >
> >
> >
> >
> > It’s not that people hate email, but a mailing list without search is a bad 
> > way to keep track of the patches. If some people are still unconvinced that 
> > it’s the current situation is not ideal, just have a look at the last path 
> > that Holger Dell sent: 
> > https://lists.zx2c4.com/pipermail/password-store/2020-May/004134.html.
> >
> >
> > This solves a very painful issue, when an empty password as been saved 
> > using `pass insert ‘’` which can happen when pass is called from another 
> > process, it will completely break `pass`, `pass show` and any plugin that 
> > uses those commands. This is a major bug!
> >
> > Now, Holger Dell spent time debugging, implementing a fix and sending it to 
> > the mailing list. That’s nice. What is less good is that this bug was 
> > already reported:
> >
> >
> > - Andrea Gazzaniga had this issue: 
> > https://lists.zx2c4.com/pipermail/password-store/2019-November/003807.html
> > - Vladimir Zhelezoff had this issue: 
> > https://lists.zx2c4.com/pipermail/password-store/2019-November/003809.html
> > - I had this issue
> > - I sent a patch to fix this issue: 
> > https://lists.zx2c4.com/pipermail/password-store/2019-July/003698.html
> > - Doan Tran Cong Danh sent a patch to fix this issue: 
> > https://lists.zx2c4.com/pipermail/password-store/2019-November/003815.html
> >
> > That’s a lot of people for such a bug and all this could be avoided with a 
> > list of currently known issues and waiting path (as far as know it’s not 
> > even possible to make a search in the mailing list archive).
> >
> > Of course, I can make a fork and maintain a fixed version of patch. But 
> > then, should I convince the distribution packager to use my fork instead?
> >
> > What about patches that I cannot test? Aren’t we diluting the community’s 
> > effort.
> >
> > Worse, there is many things that this mailing list does very well, when a 
> > user needs help an answer is usually quick to come and while we aren’t 
> > doing a poor job to keep track of issues and patches, some members are very 
> > helpful to review them: my patch was reviewed and improved by both HacKan 
> > and Tobias Girstmair.
> >
> >
> > Still, that’s a lot of people involved for an important issue whose fix is 
> > actually quite simple (and those are only the occurence I know of…).
> >
> > If we agree that there is room for improvement we can start looking for 
> > solutions. For helping others and reviewing patches the mailing list work 
> > great and have many advantages as other have already pointed out. We don’t 
> > need to change everything just to fix the problem we have here.
> >
> >
> > If you agree, we could try to have a quarterly thread with all thee 
> > outstanding patch and review / vote on them. Then Jason Donenfeld could 
> > pull all of them or cherry-pick some and reject others.
> >
> >
> >
> > I don’t know batch enough to review the patches but even I could track the 
> > patches and open this thread once in a while if the rest of the community 
> > and Jason Donenfeld agree that this could help.
> >
> >
> >
> >
> >
> > P.S.: I went further back in the archive to look for other occurence of 
> > this pattern:
> >
> >
> > - here’s a 2017 bug report with a 
> > https://lists.zx2c4.com/pipermail/password-store/2017-September/003051.html
> > - another bug report for the same bug was made in 2018: 
> > https://lists.zx2c4.com/pipermail/password-store/2018-July/003352.htm
> > -  I posted another patch for this in 2020: 
> > https://lists.zx2c4.com/pipermail/password-store/2020-March/003990.html and 
> > Allan Odgaard reviewed and improved it!
>
>
>
> --
> Tobias V. Langhoff

Reply via email to