Patches item #1090482, was opened at 2004-12-23 19:07 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1090482&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Parser/Compiler Group: Python 2.5 >Status: Closed >Resolution: Rejected Priority: 5 Private: No Submitted By: Dariusz Suchojad (dsuch) Assigned to: Neil Schemenauer (nascheme) Summary: Patch for bug 999042. Initial Comment: Hello, I believe this one-line patch fixes [999042] "Compiler module doesn't handle global statement correctly" bug. Without setting the 'optimized' flag compiler.pycodegen.CodeGenerator._nameOp always emits STORE_NAME and not STORE_GLOBAL opcode. After applying test_compiler passes fine. ---------------------------------------------------------------------- >Comment By: Martin v. Löwis (loewis) Date: 2006-12-11 05:48 Message: Logged In: YES user_id=21627 Originator: NO This patch is wrong. STORE_GLOBAL ought to be used even if optimization is turned off; faking it to be True may have undesirable side effects. The builtin compiler solves this problem by putting the GLOBAL_EXPLICIT scope to a name. The compiler package should do the same. Rejecting this patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1090482&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
