Patches item #1093468, was opened at 2004-12-30 21:57 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1093468&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Library (Lib) Group: Python 2.5 >Status: Closed >Resolution: Works For Me Priority: 5 Private: No Submitted By: Shannon -jj Behrens (jjinux) Assigned to: Nobody/Anonymous (nobody) Summary: socket leak in SocketServer Initial Comment: Found in Python 2.3.4 but still present in 2.5. FreeBSD 4.9 Summary: Fixed a socket leak in SocketServer.StreamRequestHandler that happens during certain exceptions. Longer version: SocketServer.StreamRequestHandler.setup sets up self.rfile and self.wfile. The parent class, SocketServer.BaseRequestHandler.__init__ does not call self.finish() if there is an exception thrown in self.handle(). Hence, such an exception leads to a leaked socket, because SocketServer.StreamRequestHandler.finish never gets called. This is a one line patch that fixes that. ---------------------------------------------------------------------- >Comment By: Martin v. Löwis (loewis) Date: 2006-12-11 06:02 Message: Logged In: YES user_id=21627 Originator: NO I still cannot reproduce the problem, and close this report. When I do the netstat, I don't see any sockets "open", instead, I see many sockets TIME_WAIT. Even after I apply the patch, this behaviour doesn't change: the sockets are still TIME_WAIT. That's actually because the operating system follows the RFCs here: it should keep entries in the socket table just in case additional packets are received after the connection shutdown. I also cannot reproduce the problem with the browser. My browser behaves just fine when I break do_GET. ---------------------------------------------------------------------- Comment By: Shannon -jj Behrens (jjinux) Date: 2005-02-24 23:23 Message: Logged In: YES user_id=30164 I guess the reason this bothers me so much is that if you have a nasty exception in your subclass of SimpleHTTPServer, because the server doesn't close the connection to the browser, the browser will just sit and wait instead of telling the user something bad happened. My patch fixes that. ---------------------------------------------------------------------- Comment By: Shannon -jj Behrens (jjinux) Date: 2005-02-24 23:10 Message: Logged In: YES user_id=30164 Edit SimpleHTTPServer.do_GET: Add "raise ValueError" at the top of the method. python SimpleHTTPServer.py Now, using a browser, go to http://localhost:8000, and reload the page many times. netstat -A inet --tcp | grep 8000 You will see many sockets open. They do go away (so I was wrong), but it may take a minute or two (literally). Just as a proof of concept, I tested to see whether I could bring the box down via this. Fortunately, it doesn't work :-/ It hovers at around 9000 open sockets, with the GC fighting to keep them down. The GC will occassionally take 10-15 seconds trying to clear everything up. Despite the fact the my patch is very simple, I think I'm going to lose this argument :-/ ---------------------------------------------------------------------- Comment By: Martin v. Löwis (loewis) Date: 2005-02-24 21:14 Message: Logged In: YES user_id=21627 jjinux, I find it hard to believe that the sockets don't get closed. Normally, with an exception, local variables survive in the traceback. Therefore, SocketServer.py sets sys.exc_traceback to None. It still might be that the SocketServer is part of a cyclic object, in which case the socket won't be closed until the GC actually runs. However, I believe the intention is that the SocketServer normally isn't cyclic. Can you provide a test case showing the problem? ---------------------------------------------------------------------- Comment By: Shannon -jj Behrens (jjinux) Date: 2005-01-18 20:59 Message: Logged In: YES user_id=30164 Unfortunately, that is not the case according to my testing. I can get it to leak sockets and never reclaim them. :-/ ---------------------------------------------------------------------- Comment By: Irmen de Jong (irmen) Date: 2005-01-16 16:55 Message: Logged In: YES user_id=129426 Looks harmless enough but aren't the sockets just garbage collected once the request has been handled? Because the request handler class is instantiated for each request and so it will be removed once done, taking the sockets with it, right? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1093468&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
