Patches item #1652328, was opened at 2007-02-05 03:45 Message generated for change (Comment added) made by nnorwitz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1652328&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Library (Lib) Group: None >Status: Closed >Resolution: Rejected Priority: 5 Private: No Submitted By: tom (tom375) >Assigned to: Neal Norwitz (nnorwitz) Summary: stream writing support in wave.py Initial Comment: allows wave files to be written to non-seekable file descriptors ---------------------------------------------------------------------- >Comment By: Neal Norwitz (nnorwitz) Date: 2007-04-20 20:54 Message: Logged In: YES user_id=33168 Originator: NO Taking advice and reject. ---------------------------------------------------------------------- Comment By: Jason Orendorff (jorend) Date: 2007-04-20 15:37 Message: Logged In: YES user_id=18139 Originator: NO Paul, if you call writeframesraw() exactly once, this would work. But yes, the patch squelches more errors than it needs to. Definitely should be rejected. ---------------------------------------------------------------------- Comment By: Paul Hankin (paulhankin) Date: 2007-03-17 09:23 Message: Logged In: YES user_id=1740099 Originator: NO The code ignores exceptions thrown during seeks and tells, skipping operations in the process. I can't see how this makes the written wave file correct. I would say this patch should be rejected. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1652328&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
