Hi Stephen, > This is useful given that these APIs can be disabled, and likely will > be for deployments where django-rest-framework is not available. > > The version is currently hardcoded, but this will be resolved in a > future change. > How are you planning on doing that? I seem to remember a previous patch that tried...
Would it make more sense to do that first and then put this in?
> + <li class="list-group-item">
> + REST
> + <span class="glyphicon glyphicon-question-sign" title="The REST
> + API"></span>
> + {% if enabled_apis.rest %}
> + <span class="label label-success pull-right">enabled</span>
> + {% else %}
> + <span class="label label-danger pull-right">disabled</span>
label-danger might be a bit extreme? I would probably go with green and
grey rather than green and red.
But this is almost the literal definition of bikeshedding so I'm not
very fussy.
Regards,
Daniel
signature.asc
Description: PGP signature
_______________________________________________ Patchwork mailing list [email protected] https://lists.ozlabs.org/listinfo/patchwork
