On 2016-10-31 21:18, Daniel Axtens wrote:
Hi Stephen,
This is useful given that these APIs can be disabled, and likely will
be for deployments where django-rest-framework is not available.
The version is currently hardcoded, but this will be resolved in a
future change.
How are you planning on doing that? I seem to remember a previous patch
that tried...
Yeah, the previous patch could do this for us, though I can't find it.
I'll resubmit.
Would it make more sense to do that first and then put this in?
It probably would, yes :)
+ <li class="list-group-item">
+ REST
+ <span class="glyphicon glyphicon-question-sign" title="The
REST
+ API"></span>
+ {% if enabled_apis.rest %}
+ <span class="label label-success pull-right">enabled</span>
+ {% else %}
+ <span class="label label-danger pull-right">disabled</span>
label-danger might be a bit extreme? I would probably go with green and
grey rather than green and red.
+1
Stephen
_______________________________________________
Patchwork mailing list
[email protected]
https://lists.ozlabs.org/listinfo/patchwork
