On Fri, 20 Aug 2021 at 17:59, Stephen Finucane <step...@that.guru> wrote:
> > We remove fields that shouldn't be seen on old versions of the API.
> > This was done with `pop(field name)`, which will throw an exception
> > if the named field is absent from the data. However, sometimes if
> > a patch request is via an old API version, we hit this line without
> > ever having the field present.
> >
> > This is odd, but not harmful and we definitely shouldn't 500.
> >
> > Fixes: d944f17ec059 ("REST: Use versioning for modified responses")
> > Signed-off-by: Daniel Axtens <d...@axtens.net>
>
> Looks good to me.
>
> Reviewed-by: Stephen Finucane <step...@that.guru>
>
> I squashed the test into this (with a tweak in the name) and applied it.Hi, all: Could this please be backported to stable/2.2 and maybe released as 2.2.6? -K _______________________________________________ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
