On Nov 9, 2011, at 11:14 AM, katja wrote: > On Wed, Nov 9, 2011 at 4:58 AM, Hans-Christoph Steiner <[email protected]> wrote: > >>> Ah these typedefs are nonsense indeed, t_float and t_floatarg are >>> defined in msp's zdsp.h as well, at least since Max/Msp5, earlier >>> versions I don't know. >> >> >> Ah I see, they are for Max/MSP only? I didn't notice that before. So I >> guess the thing to do would be for you do make adjustments in the >> pd-double.git, then we can rebase into a patch for just extra and submit it >> for Miller. I think these changes are worth getting into pure-data.git now >> since in 0.42 Miller already went thru the core source code to make sure all >> of the t_float and t_sample types were used where they made sense. >> > > Checked it once more, t_float and t_sample are defined in zdsp.h at > least in Max/Msp version 4.6 and 5 (not t_floatarg however, a float > argument is always a double in Max/Msp). Since zdsp.h is included in > all cases, I should leave t_float and t_sample typedefs out indeed. > I'll do the adjustments in pd-double.git. Remarkably, t_float is not > defined in the max-includes (for non-signal classes) in Max/Msp. > > So far I have just turned float into t_float. Only when t_sample and > t_float are used consistently throughout all Pd(-extended) code, it > would be possible to define them differently. Meaning, there must > never be an implicit or explicit t_sample<>t_float pointer cast. To > check/implement this is more work than just making double-ready. > Should we do it nonetheless, or leave this for a next clean-up? Or > maybe I should do it for pure-data's extra's now, before submitting a > patch for pure-data.git?
I think we should submit the current changes now since they will get things building at double-precision at least. Then further fixes can be submitted later. .hc ---------------------------------------------------------------------------- Using ReBirth is like trying to play an 808 with a long stick. -David Zicarelli _______________________________________________ Pd-dev mailing list [email protected] http://lists.puredata.info/listinfo/pd-dev
