I could change it to separate it from the rest. But probably i'll need some directions as i'm a newbie.
Some stuff is already separated such as the hotkey handling which is done in kbdnav_key<https://github.com/HenriAugusto/pure-data/blob/f5c39cb5cd7ebc101b0b3d9dcde28491b2093b57/src/g_editor.c#L5025> instead of canvas_key (which is already very long). But there is stuff like the drawing of the rectangles to indicate which in/outlet is selected for example, which is done in glist_drawiofor<https://github.com/HenriAugusto/pure-data/blob/f5c39cb5cd7ebc101b0b3d9dcde28491b2093b57/src/g_text.c#L1365> inside g_texc.c. Also, in g_canvas.h, inside the "struct _editor" there is a "struct _kbdnav" member. This is the struct that contains the data used in the keyboard navigation. So how one should go to keep everything optional? Using preprocessor #if's to include/exclude code during compilation? ________________________________ De: Miller Puckette <[email protected]> Enviado: quarta-feira, 12 de junho de 2019 00:48 Para: Dan Wilcox Cc: Henri Augusto Bisognini; pd-dev Assunto: Re: [PD-dev] First complete keyboard navigation prototype I agree - I haven't looked at the code but if it can fit easily into Pd's source tree as a run-time option this would be worth adding. cheers M On Mon, Jun 10, 2019 at 01:59:35PM +0200, Dan Wilcox wrote: > *Not really feedback, but just a general response.* > > One thing I would suggest would be to make this an optional feature in some > way. Maybe we can work together with IOhannes and Christof to propose changes > to the Pd sources to allow for adding in this kind of functionality without > *requiring* it to be built into the core itself. I have been thinking of > these kinds of approaches since I see this being a greta feature for the GUI > but basically unused for something like libpd. In the latter case, I'd like > to simply not compile it and the easiest way would if the main functionality > is in a separate set of files that can be left out. > > This might be a process that has to happen later on, but something to think > of for now in order to balance the addition of new features while maintaining > the possibility for a fast, slim core. > > > On Jun 10, 2019, at 10:30 AM, [email protected] wrote: > > > > Date: Sun, 9 Jun 2019 19:16:36 +0000 > > From: Henri Augusto Bisognini <[email protected] > > <mailto:[email protected]>> > > To: "[email protected] <mailto:[email protected]>" <[email protected] > > <mailto:[email protected]>> > > Subject: Re: [PD-dev] First complete keyboard navigation prototype > > Message-ID: > > > > <cp2pr80mb0386c0d2c66d1ce34f458be3cc...@cp2pr80mb0386.lamprd80.prod.outlook.com > > > > <mailto:cp2pr80mb0386c0d2c66d1ce34f458be3cc...@cp2pr80mb0386.lamprd80.prod.outlook.com>> > > > > Content-Type: text/plain; charset="iso-8859-1" > > > > Thanks Christof! Indeed it's already been very nice to use it during my > > tests. > > > > I'l probably wrap up a small file containing some basic infos about how > > everything works to make it easier for more people to modify the code and > > test ideas. > > -------- > Dan Wilcox > @danomatika <http://twitter.com/danomatika> > danomatika.com <http://danomatika.com/> > robotcowboy.com <http://robotcowboy.com/> > > > > _______________________________________________ > Pd-dev mailing list > [email protected] > https://lists.puredata.info/listinfo/pd-dev
_______________________________________________ Pd-dev mailing list [email protected] https://lists.puredata.info/listinfo/pd-dev
