> Both functions can be implemented in the pdf_time module.

   Yes, maybe could be easier to directly update the API with two new 
   functions, both passing as argument the number of seconds since unix 
   timescale origin:

I think that this is a good solution.

   pdf_time_set_from_i32(pdf_time_t time_object,
                          pdf_i32_t seconds);

   pdf_time_set(pdf_time_t time_object, \
                 pdf_i32_t high, pdf_u32_t low);

   Plus maybe an additional one to be used in Windows, which involves also 
   the timescale change (filetime to systime):
   pdf_time_set_from_filetime(pdf_time_t time_object, \
                               pdf_i32_t high, pdf_u32_t low);

If this function is only being used when compiling/running in windows
then it is useful to identify that fact in the function name. Also,
platform-specific functions should be documented in a separate section
in the reference manual.



Reply via email to