On Thu, 2014-04-24 at 02:12 +0400, Dmitry Koterov wrote: > ========================================== > > Before the line: > > > https://github.com/php/php-src/blob/master/run-tests.php#L264 > > > add the following line: > > > unset($info_params['extension']); > > ========================================== > > > > - this solves the problem. This simple line turns off loading of > extension which were passed via command-line to run-tests.php (as "-d > extension=zzz") ONLY during the "PHP Info" stage (this stage is just > to show something extension-independent at the screen, it does not > affect on the following tests runs; at the same time, real tests > execution code rely on "--EXTENSIONS--" section in phpt files which is > processed by run-tests.php correctly, e.g. > https://github.com/DmitryKoterov/dom_varimport/blob/master/tests/002_formats.phpt#L5 > ). > > > How do you think, do I have a chance to push this change into the > official PHP repo?
I haven't looked deeper and don't remember all the details from previous discussions but in general: Yes!!! :-) Can you create pull request against github.com/php/php-src and drop a mail to internals? If nobody complains and some test it we can push it, and if we lateron find issues in specific scenarios we can revise it, run-tests is not that a critical component so try&revert is simpler to do than i.e. in the core engine ;) johannes -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
