On Sa, 2017-11-11 at 11:47 +0100, Remi Collet wrote: > Joe have a new extension https://github.com/krakjoe/wkhtmltox > > This extension wraps libwkhtmltox for PHP 7.
Two quick comments on this: In RINIT this starts up a QApplication context (via wkhtmltopdf_init) for each request, even if the functionality is not used. Either this should be delayed till first request to the extension is being made or this should be done in MINIT (might be problematic with forking SAPI environments) Secondly: The wkhtml library uses global state in non-thread-safe manner it seems. (only spent 5 minutes on this in total ...) config.m4 should disallow building in threaded context. > I will take care of the release process > > Can you please create the project, so I can upload it ? I would assume you have the power yourself, can you try? Try via https://pecl.php.net/package-new.php johannes -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
