It was Friday, December 24, 2004 when Scott McWhirter took the soap box, saying: : Well.. I "Just Fucking Did it". So attached is the initial module, with : testsuite, documentation and coverage details. I'll not upload it via : PAUSE until I hear some responses. The code is also available via SVN : from http://svn.narnia.org.uk though if wanted I'll mirror to CVS.
rcpt_to() and mail_from() don't allow for multiple addresses. Representing a complete and valid SMTP conversation with Email::Envelope won't work. Your Email::Address usage seems to be wrong as well. ->new() takes three arguments, the first always being the phrase, second the address, and third the comment. You probably wanted to call ->parse() and even then, it returns a list. This matters less, but there are conventions used in method naming and parameter passing within the PEP. I say it matters less because it started with whatever Simon wanted to do and we've generally kept it that way, but what does it really matter? In any case, those conventions include seperate accessors and mutators, and passing flat key/value paramaters instead of hash references. I'm not going to tell you to change what you have, merely noting the differences. As for secure(), it is up to the module user to decide if mail is secure by whatever means she deems secure. So I'm fine with a boolean. Casey West -- Shooting yourself in the foot with Ada After correctly packaging your foot, you attempt to concurrently load the gun, pull the trigger, scream and shoot yourself in the foot. When you try, however, you discover that your foot is of the wrong type.
