Casey West wrote:
rcpt_to() and mail_from() don't allow for multiple
addresses. Representing a complete and valid SMTP conversation with
Email::Envelope won't work.
>
Your Email::Address usage seems to be wrong as well. ->new() takes
three arguments, the first always being the phrase, second the
address, and third the comment. You probably wanted to call ->parse()
and even then, it returns a list.
Fixed. Documentation notes the differences.

This matters less, but there are conventions used in method naming and
parameter passing within the PEP. I say it matters less because it
started with whatever Simon wanted to do and we've generally kept it
that way, but what does it really matter? In any case, those
conventions include seperate accessors and mutators, and passing flat
key/value paramaters instead of hash references. I'm not going to tell
you to change what you have, merely noting the differences.
I'm not convinced that seperate accessors/mutators are beneficial only for the sake of a loose convention. It means more work in both tests and in code. If you're very keen, I'll make the change.

As for secure(), it is up to the module user to decide if mail is
secure by whatever means she deems secure. So I'm fine with a
boolean.

agreed. I have also added mta_msg_id and recieved_timestamp.

Sorry about lateness, 2 weeks in japan on vacation was _rather_ distracting. However new version attached for your perusal.

ta!


-- -Scott McWhirter-

Attachment: Email-Envelope-0.00_02.tar.gz
Description: Binary data



Reply via email to